After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 669793 - GcrPrompt should allow setting button labels
GcrPrompt should allow setting button labels
Status: RESOLVED FIXED
Product: gcr
Classification: Core
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME keyring maintainer(s)
GNOME keyring maintainer(s)
Depends on:
Blocks: 652459
 
 
Reported: 2012-02-10 08:38 UTC by Stef Walter
Modified: 2019-02-22 11:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gcr: Add way to set the labels for the prompt buttons (19.74 KB, patch)
2012-02-10 13:01 UTC, Stef Walter 		none Details | Review
Use non-pageable memory for gnome-keyring passwords (12.33 KB, patch)
2012-02-10 16:42 UTC, Stef Walter 		rejected Details | Review

Description Stef Walter 2012-02-10 08:38:36 UTC 
The ok/cancel button labels should depend on context and should be part of the information that's settable in a GcrPrompt.

Needed for gnome-shell integration.
Comment 1 Stef Walter 2012-02-10 13:01:46 UTC 
Created attachment 207242 [details] [review]
gcr: Add way to set the labels for the prompt buttons

 * Add continue-label and cancel-label properties to GcrPrompt
 * Implement in GcrSystemPrompt and in the mock prompter
Comment 2 Stef Walter 2012-02-10 15:32:44 UTC 
Merged into gcr, and released as part of 3.3.5 release.
Comment 3 Stef Walter 2012-02-10 16:42:50 UTC 
Created attachment 207273 [details] [review]
Use non-pageable memory for gnome-keyring passwords

 * Use a ClutterTextBuffer that allocates non-pageable
   memory to hold passwords for gnome-keyring, ssh, gpg
 * Requires gcr 3.3.5 and clutter 1.9.4
Comment 4 Stef Walter 2012-02-10 16:45:42 UTC 
Comment on attachment 207273 [details] [review]
Use non-pageable memory for gnome-keyring passwords

Attached this patch to the wrong bug, sorry.