After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 669712 - Should not allow the user to set a negative priority on XMPP
Should not allow the user to set a negative priority on XMPP
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Accounts
3.3.x
Other Linux
: Normal major
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2012-02-08 22:39 UTC by Will Thompson
Modified: 2012-02-09 11:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
account-widget-jabber: doesn't allow negative priority (1.09 KB, patch)
2012-02-09 11:53 UTC, Guillaume Desmottes 		committed Details | Review

Description Will Thompson 2012-02-08 22:39:29 UTC 
On XMPP, resources with negative priority mean “don't deliver IMs to me”. So if a user happens to set their priority to -3 (whether by mistake, or by tinkering and wondering what this option does, they will silently lose data. I do not think Empathy should expose a seemingly-innocuous option—even one marked as Advanced—which causes data loss.

(This isn't hypothetical: a contact has been wondering why he wasn't receiving any messages for months, and I guessed negative priority on the off-chance…)
Comment 1 Guillaume Desmottes 2012-02-09 11:53:02 UTC 
Created attachment 207181 [details] [review]
account-widget-jabber: doesn't allow negative priority

Setting a negative priority secretly mean "don't send me any message" which
can be very confusing.
Comment 2 Guillaume Desmottes 2012-02-09 11:55:05 UTC 
Attachment 207181 [details] pushed as 5c9ffe7 - account-widget-jabber: doesn't allow negative priority