After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 669636 - gtkactiongroup: clarify set_translation_domain docs
gtkactiongroup: clarify set_translation_domain docs
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Documentation
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2012-02-08 08:36 UTC by Diego Escalante Urrelo (not reading bugmail)
Modified: 2012-02-08 09:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gtkactiongroup: clarify set_translation_domain docs (1.16 KB, patch)
2012-02-08 08:36 UTC, Diego Escalante Urrelo (not reading bugmail) 		reviewed Details | Review
gtkactiongroup: clarify set_translation_domain docs (1.17 KB, patch)
2012-02-08 09:23 UTC, Diego Escalante Urrelo (not reading bugmail) 		committed Details | Review

Description Diego Escalante Urrelo (not reading bugmail) 2012-02-08 08:36:23 UTC 
A small proposal to make it clear that NULL is ok.
Comment 1 Diego Escalante Urrelo (not reading bugmail) 2012-02-08 08:36:26 UTC 
Created attachment 207066 [details] [review]
gtkactiongroup: clarify set_translation_domain docs

NULL is an actual useful value for
gtk_action_group_set_translation_domain, but this information is buried
in g_dgettext() documentation.

Be extra redundant, to make it obvious that NULL is ok.
Comment 2 Emmanuele Bassi (:ebassi) 2012-02-08 09:11:32 UTC 
Review of attachment 207066 [details] [review]:

looks good to me.

::: gtk/gtkactiongroup.c
@@ +1407,3 @@
  * gtk_action_group_set_translation_domain:
  * @action_group: a #GtkActionGroup
+ * @domain: the translation domain to use for g_dgettext() calls, or

adding (allow-none) would also make language bindings happier
Comment 3 Diego Escalante Urrelo (not reading bugmail) 2012-02-08 09:23:51 UTC 
Created attachment 207071 [details] [review]
gtkactiongroup: clarify set_translation_domain docs

NULL is an actual useful value for
gtk_action_group_set_translation_domain, but this information is buried
in g_dgettext() documentation.

Be extra redundant, to make it obvious that NULL is ok.

= 

Updated.
Comment 4 Emmanuele Bassi (:ebassi) 2012-02-08 09:33:48 UTC 
Review of attachment 207071 [details] [review]:

looks good to me.
Comment 5 Diego Escalante Urrelo (not reading bugmail) 2012-02-08 09:38:32 UTC 
Done. Thanks!