GNOME Bugzilla – Bug 669624
Preview next block doesn't work
Last modified: 2013-05-24 01:33:14 UTC
I have Preview Next Block checked in Quadrapassel's preferences but the black preview area in the top right corner stays black and empty. I believe this worked before the switch to Vala. quadrapassel 3.3.5 on Ubuntu 12.04 "Alpha" on amd64.
This is working for me and also working for the packaged version. Any log messages / can you test on another video driver?
I don't see any log messages when run like normal from the terminal. My primary computer is using Intel graphics but I also verified this bug on my wife's computer which uses Nouveau.
Jeremy, So do you use the 'difficult block' mode? When I use the 'difficult block', there are no image of the next block, when I cancel the selection, it show again.
Created attachment 242090 [details] [review] Patch disabling preview toggle when difficult block mode is enabled This patch should make it abundantly clear that preview-mode is dependent on difficult block mode being disabled. (it disables the preview-mode-toggle if difficult-block-mode is enabled) Either that or we actually do precalculate one block to be shown, which should prove rather difficult.
Review of attachment 242090 [details] [review]: Well if it'd be too much work to have both options at the same time, then this fix works great. There is only one problem: if checking a checkbox marks other checkboxes as insensitive, then that box should be above (or to the left of) the affected boxes. So we just need to flip tho order of these checkboxes in the UI (or have difficult block mode depend on preview mode, instead of the other way around, but I think your way makes more sense). We should also change the default settings so that whichever option is disabled by default isn't checked by default. Both of those changes are trivial and can be done separately from this patch, but should be done before this is committed. I also notice that the black box should also be hidden when this previews are off, but that's a completely separate bug.
Created attachment 244226 [details] [review] Don't pick difficult blocks by default
Created attachment 244227 [details] [review] Flip the two settings To be applied after the original patch
Created attachment 245083 [details] [review] allow previews of difficult blocks Mario, Thanks for the assistance with fixing the preferences dialog to make clear that these two options can't be used at the same time! While looking at this further, I found that it was quite easy to allow both options to function properly at the same time, so I'm going to push that change instead.
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.
But this changes the concept of difficult block mode as the most difficult block isn't picked on the current layout of the board but on the layout of the board before the current piece. So the hard-block-selector can't choose the actual hardest block. So you can prepare beforehand and it becomes like standard mode, doesn't it?
Maybe we could just show a big question mark in the preview for the hard-block mode?
Either that or disabling preview (both viable):. But I don't think, we should make it easier. A question mark is a nice alternative.
(In reply to comment #10) > But this changes the concept of difficult block mode as the most difficult > block isn't picked on the current layout of the board but on the layout of the > board before the current piece. Good point, it's based on the turn prior. Seems best to just revert my patch and go with the ones we already had prepared. Mario's "hide preview entirely" patch works well enough that we won't need a question mark.
OK, damage undone. We still need to make checking difficult block mode disable the previews.
Well, no, it looks like difficult block mode is set on a per-game basis, so with both of Mario's patches, everything just works. Mario, if anything's still wrong with either master or gnome-3-8, please let us know.