After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 669538 - Fix compilation (eliminate warnings) of glib-compile-resources.c on Windows
Fix compilation (eliminate warnings) of glib-compile-resources.c on Windows
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
2.31.x
Other Windows
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2012-02-07 06:49 UTC by Fan, Chun-wei
Modified: 2012-02-10 00:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
glib-compile-resources.c: Include io.h on Windows (840 bytes, patch)
2012-02-07 06:49 UTC, Fan, Chun-wei 		accepted-commit_now Details | Review

Description Fan, Chun-wei 2012-02-07 06:49:06 UTC 
Created attachment 206954 [details] [review]
glib-compile-resources.c: Include io.h on Windows

Hi,

I have added Visual C++ projects to compile the new GResource tools on Windows, and found that glib-compile-resources.c required a minor update to avoid C4013 (aka Implicit declaration of ...) warnings/errors for close(), namely to include io.h on that platform.  The enclosed trivial patch does that.

p.s. A quick question-will it be better to dist the generated gconstructor_as_data.h instead of generating it in the Visual C++ projects, which will require an additional dependency on a PERL installation?

With blessings.  Thank you!
Comment 1 Matthias Clasen 2012-02-10 00:43:39 UTC 
Review of attachment 206954 [details] [review]:

Patch looks fine
Comment 2 Matthias Clasen 2012-02-10 00:46:03 UTC 
Includeing a generated header file sounds fine to me.
Comment 3 Fan, Chun-wei 2012-02-10 00:59:19 UTC 
Hi,

The attachment 206954 [details] [review] was pushed as d4e3ae9.

With blessings-thank you!