After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 669366 - screenshot_area() misses target rect
screenshot_area() misses target rect
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.3.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-02-04 15:53 UTC by Tobias Wolf
Modified: 2012-02-04 16:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenGrabber: Pass correct coordinates to glReadPixels (1005 bytes, patch)
2012-02-04 15:59 UTC, drago01 		committed Details | Review

Description Tobias Wolf 2012-02-04 15:53:37 UTC 
The area screenshot now shoots with an offset from the given rectangle, i.e.,
it misses the rect selection given with <x, y, width, height> and shifts to the
lower left. Could this be related to cosimoc’s commit 9147dee0 "screenshot: use
the correct offsets when calculating the window area". 

This screenshot in [1] came out when it was given the rectangle seen in [0]. This worked in December.

[0] https://bugzilla.gnome.org/attachment.cgi?id=206763
[1] https://bugzilla.gnome.org/attachment.cgi?id=206764
Comment 1 Tobias Wolf 2012-02-04 15:55:43 UTC 
I tested this with gnome-shell-extension-area-screenshot.

The used code is at:
https://github.com/DASPRiD/gnome-shell-extension-area-screenshot/blob/master/area-screenshot@dasprids.de/extension.js
Comment 2 drago01 2012-02-04 15:59:23 UTC 
Created attachment 206768 [details] [review]
screenGrabber: Pass correct coordinates to glReadPixels

Pass x and y to glReadPixels rather then always 0, 0.
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-02-04 16:04:16 UTC 
Review of attachment 206768 [details] [review]:

Hah, I had noted that when Owen originally posted the code on IRC. Thought he would have fixed it.
Comment 4 drago01 2012-02-04 16:07:34 UTC 
Attachment 206768 [details] pushed as 8755941 - screenGrabber: Pass correct coordinates to glReadPixels