After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 669330 - glocalfile: fix error code when opening a directory on win32
glocalfile: fix error code when opening a directory on win32
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2012-02-03 18:06 UTC by Dan Winship
Modified: 2012-02-09 11:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
glocalfile: fix error code when opening a directory on win32 (1.99 KB, patch)
2012-02-03 18:06 UTC, Dan Winship 		committed Details | Review

Description Dan Winship 2012-02-03 18:06:36 UTC 
g_file_read() was returning G_IO_ERROR_IS_DIRECTORY when you tried to
open a directory on unix, but G_IO_ERROR_PERMISSION_DENIED on win32.
Fix that, and add a test to tests/file.c

Pointed out on IRC by Paweł Forysiuk.
Comment 1 Dan Winship 2012-02-03 18:06:38 UTC 
Created attachment 206699 [details] [review]
glocalfile: fix error code when opening a directory on win32
Comment 2 Matthias Clasen 2012-02-09 11:36:49 UTC 
Review of attachment 206699 [details] [review]:

Sure, ok
Comment 3 Dan Winship 2012-02-09 11:48:26 UTC 
Attachment 206699 [details] pushed as ca5ed93 - glocalfile: fix error code when opening a directory on win32