After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 669167 - vorbisparse drops certain data buffers on the floor mistakenly thinking they're headers
vorbisparse drops certain data buffers on the floor mistakenly thinking they'...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
0.10.x
Other Linux
: Normal normal
: 0.10.36
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-02-01 13:06 UTC by Vincent Penquerc'h
Modified: 2012-02-02 20:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
vorbisparse: fix header detection (1.10 KB, patch)
2012-02-01 16:34 UTC, Vincent Penquerc'h 		committed Details | Review

Description Vincent Penquerc'h 2012-02-01 13:06:24 UTC 
gst-launch-0.10 filesrc location=... ! oggdemux ! vorbisparse ! fakesink

One file leaks one buffer.
Another file leaks 707 buffers (ouch).

The number of leaked buffers is the same per file.

Filing so I don't forget to fix.
Comment 1 Vincent Penquerc'h 2012-02-01 16:34:48 UTC 
Created attachment 206578 [details] [review]
vorbisparse: fix header detection

It was matching non header packets.

This fixes various leaks, where buffers would be pushed onto a headers
list, but never popped.

Might also fix corruption as those buffers were dropped from the output
silently...
Comment 2 Vincent Penquerc'h 2012-02-01 16:48:59 UTC 
Pushed:

commit b647c627e4ad54cec2c1058e1264ef4239665e6d
Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date:   Wed Feb 1 16:46:13 2012 +0000

    vorbisparse: pedantically recognize undefined headers too

commit 809546c324b86fbfe37de8ce5543d03d2206a2f2
Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date:   Wed Feb 1 16:32:24 2012 +0000

    vorbisparse: fix header detection
    
    It was matching non header packets.
    
    This fixes various leaks, where buffers would be pushed onto a headers
    list, but never popped.
    
    Might also fix corruption as those buffers were dropped from the output
    silently...
    
    https://bugzilla.gnome.org/show_bug.cgi?id=669167
Comment 3 Tim-Philipp Müller 2012-02-02 20:56:38 UTC 
cherry-picked this into the release branch, so -> 0.10.36