After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 66913 - Gnome Help Browser crashes
Gnome Help Browser crashes
Status: RESOLVED FIXED
Product: gnome-core
Classification: Deprecated
Component: help-browser
1.4.x
Other other
: Normal normal
: 1.4.1
Assigned To: gnome-core Maintainers
gnome-core Maintainers
: 51299 60237 61638 64987 65040 66109 68286 68667 69232 69276 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2001-12-13 22:45 UTC by asensio
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Increase error checkin (538 bytes, patch)
2002-01-10 03:35 UTC, Wayne Schuller
none Details | Review

Description asensio 2001-12-13 22:45:51 UTC
Package: gnome-core
Severity: normal
Version: 1.4.0.2
Synopsis: Gnome Help Browser crashes
Bugzilla-Product: gnome-core
Bugzilla-Component: help-browser

Description:
I was reading the evolution help and one time that I clicked "next" gnome-help-browser crashed


Debugging Information:

(no debugging symbols found)...(no debugging symbols found)...
(no debugging symbols found)...(no debugging symbols found)...
(no debugging symbols found)...(no debugging symbols found)...
(no debugging symbols found)...(no debugging symbols found)...
(no debugging symbols found)...(no debugging symbols found)...
(no debugging symbols found)...(no debugging symbols found)...
(no debugging symbols found)...(no debugging symbols found)...
(no debugging symbols found)...(no debugging symbols found)...
(no debugging symbols found)...(no debugging symbols found)...
(no debugging symbols found)...(no debugging symbols found)...
(no debugging symbols found)...(no debugging symbols found)...
(no debugging symbols found)...(no debugging symbols found)...
(no debugging symbols found)...(no debugging symbols found)...
(no debugging symbols found)...(no debugging symbols found)...
(no debugging symbols found)...(no debugging symbols found)...
(no debugging symbols found)...(no debugging symbols found)...
(no debugging symbols found)...(no debugging symbols found)...
(no debugging symbols found)...(no debugging symbols found)...
(no debugging symbols found)...(no debugging symbols found)...
(no debugging symbols found)...0x4064a919 in wait4 () from /lib/libc.so.6
  • #0 wait4
    from /lib/libc.so.6
  • #1 __check_rhosts_file
    from /lib/libc.so.6
  • #2 gnome_init
    from /usr/lib/libgnomeui.so.32
  • #3 sigaction
    from /lib/libc.so.6
  • #4 _XmHTMLInfoToPixmap
    from /usr/lib/libgtkxmhtml.so.1
  • #5 _XmHTMLImageFileToBuffer
    from /usr/lib/libgtkxmhtml.so.1
  • #6 _XmHTMLImageCheckDelayedCreation
    from /usr/lib/libgtkxmhtml.so.1
  • #7 _XmHTMLComputeLayout
    from /usr/lib/libgtkxmhtml.so.1
  • #8 _XmHTMLRecomputeShadowColors
    from /usr/lib/libgtkxmhtml.so.1
  • #9 _XmHTMLCheckXCC
    from /usr/lib/libgtkxmhtml.so.1
  • #10 _XmHTMLCheckXCC
    from /usr/lib/libgtkxmhtml.so.1
  • #11 _XmHTMLCheckXCC
    from /usr/lib/libgtkxmhtml.so.1
  • #12 gtk_xmhtml_source
    from /usr/lib/libgtkxmhtml.so.1
  • #13 helpWindowHTMLSource
  • #14 visitURL
  • #15 visitURL
  • #16 visitURL
  • #17 helpWindowShowURL
  • #18 map_spaces_to_underscores
  • #19 _init
    from /usr/lib/libgtkxmhtml.so.1
  • #20 gtk_signal_remove_emission_hook
    from /usr/lib/libgtk-1.2.so.0
  • #21 gtk_signal_set_funcs
    from /usr/lib/libgtk-1.2.so.0
  • #22 gtk_signal_emit
    from /usr/lib/libgtk-1.2.so.0
  • #23 _XmHTMLActivateCallback
    from /usr/lib/libgtkxmhtml.so.1
  • #24 _XmHTMLClearArea
    from /usr/lib/libgtkxmhtml.so.1
  • #25 gtk_marshal_BOOL__POINTER
    from /usr/lib/libgtk-1.2.so.0
  • #26 gtk_signal_remove_emission_hook
    from /usr/lib/libgtk-1.2.so.0
  • #27 gtk_signal_set_funcs
    from /usr/lib/libgtk-1.2.so.0
  • #28 gtk_signal_emit
    from /usr/lib/libgtk-1.2.so.0
  • #29 gtk_widget_event
    from /usr/lib/libgtk-1.2.so.0
  • #30 gtk_propagate_event
    from /usr/lib/libgtk-1.2.so.0
  • #31 gtk_main_do_event
    from /usr/lib/libgtk-1.2.so.0
  • #32 gdk_wm_protocols_filter
    from /usr/lib/libgdk-1.2.so.0
  • #33 g_get_current_time
    from /usr/lib/libglib-1.2.so.0
  • #34 g_get_current_time
    from /usr/lib/libglib-1.2.so.0
  • #35 g_main_run
    from /usr/lib/libglib-1.2.so.0
  • #36 gtk_main
    from /usr/lib/libgtk-1.2.so.0
  • #37 main
  • #38 __libc_start_main
    from /lib/libc.so.6
  • #0 wait4
    from /lib/libc.so.6
  • #1 __check_rhosts_file
    from /lib/libc.so.6
  • #2 gnome_init
    from /usr/lib/libgnomeui.so.32
  • #3 sigaction
    from /lib/libc.so.6
  • #4 _XmHTMLInfoToPixmap
    from /usr/lib/libgtkxmhtml.so.1
  • #5 _XmHTMLImageFileToBuffer
    from /usr/lib/libgtkxmhtml.so.1
  • #6 _XmHTMLImageCheckDelayedCreation
    from /usr/lib/libgtkxmhtml.so.1
  • #7 _XmHTMLComputeLayout
    from /usr/lib/libgtkxmhtml.so.1




------- Bug moved to this database by unknown@bugzilla.gnome.org 2001-12-13 17:45 -------

The original reporter (asensio@wanadoo.es) of this bug does not have an account here.
Reassigning to the exporter, unknown@bugzilla.gnome.org.
Reassigning to the default owner of the component, gnome-core-maint@bugzilla.gnome.org.

Comment 1 Wayne Schuller 2002-01-06 19:14:14 UTC
Just to get it into bugzilla.

The fix for this is a one-liner with gtk-xmhtml (in gnome-libs).

I posted it to gnome-libs-devel:
http://mail.gnome.org/archives/gnome-libs-devel/2002-January/msg00006.html

But here it is:
--- gnome-libs-1.4.1.2/gtk-xmhtml/images.c	Wed Jun 28 07:43:25 2000
+++ gnome-libs-1.4.1.2hacking/gtk-xmhtml/images.c	Mon Jan  7 02:24:57
2002
@@ -2390,7 +2395,7 @@
 
	{
 
		if(!html->html.xcc)
 
			_XmHTMLCheckXCC(html);
-
		image->xcc = html->html.xcc;
+
		xcc = image->xcc = html->html.xcc;
 
	}
 	}
 
Comment 2 Kjartan Maraas 2002-01-08 23:52:42 UTC
Commited. Thanks.
Comment 3 Wayne Schuller 2002-01-09 01:53:49 UTC
*** Bug 65040 has been marked as a duplicate of this bug. ***
Comment 4 Wayne Schuller 2002-01-09 01:55:59 UTC
*** Bug 60237 has been marked as a duplicate of this bug. ***
Comment 5 Wayne Schuller 2002-01-09 01:56:37 UTC
*** Bug 61638 has been marked as a duplicate of this bug. ***
Comment 6 Wayne Schuller 2002-01-09 02:00:37 UTC
*** Bug 64987 has been marked as a duplicate of this bug. ***
Comment 7 Kjartan Maraas 2002-01-09 20:28:02 UTC
Hmm. After applying this I get the following crash in help browser. To
reproduce: Foot-menu->Run->help

If you can fix this too you'll the bughero of the week :)

no debugging symbols found)...0x4063ca49 in __wait4 ()
   from /lib/i686/libc.so.6
  • #0 __wait4
    from /lib/i686/libc.so.6
  • #1 __DTOR_END__
    from /lib/i686/libc.so.6
  • #2 gnome_segv_handle
    at gnome-init.c line 666
  • #3 <signal handler called>
  • #4 png_read_destroy
    from /usr/lib/libpng.so.2
  • #5 png_destroy_read_struct
    from /usr/lib/libpng.so.2
  • #6 _XmHTMLReadPNG
    at readPNG.c line 298
  • #7 readImage
    at images.c line 395
  • #8 XmHTMLImageDefaultProc
    at images.c line 4389
  • #9 load_image
  • #10 _XmHTMLNewImage
    at images.c line 3508
  • #11 ImageToWord
    at format.c line 1000
  • #12 _XmHTMLformatObjects
    at format.c line 3423
  • #13 gtk_xmhtml_sync_reformat
    at gtk-xmhtml.c line 1615
  • #14 gtk_xmhtml_sync
    at gtk-xmhtml.c line 1668
  • #15 helpWindowHTMLSource
  • #16 visitURL
  • #17 visitURL
  • #18 visitURL
  • #19 helpWindowShowURL
  • #20 main
  • #21 __libc_start_main
    at ../sysdeps/generic/libc-start.c line 129
  • #0 __wait4
    from /lib/i686/libc.so.6
  • #1 __DTOR_END__
    from /lib/i686/libc.so.6
  • #2 gnome_segv_handle
    at gnome-init.c line 666
  • #3 <signal handler called>
  • #4 png_read_destroy
    from /usr/lib/libpng.so.2
  • #5 png_destroy_read_struct
    from /usr/lib/libpng.so.2
  • #6 _XmHTMLReadPNG
    at readPNG.c line 298
  • #7 readImage
    at images.c line 395

Comment 8 Wayne Schuller 2002-01-10 03:35:34 UTC
Created attachment 6365 [details] [review]
Increase error checkin
Comment 9 Wayne Schuller 2002-01-10 03:42:38 UTC
I can't reproduce your bug.

The above patch is a one-liner to check the result of a function that
'should' never fail. It's based on your stack trace.

It is a crappy patch because it just tries to avoid the segfault,
rather than figure out what is going wrong at the deeper level.

gtkhtml is 1.0.0 now, so we can assume the API has stabilised. How
hard would it be to update the gtkhtml support to 1.0.0 and make that
the default for the next gnome-libs release?

gtk-xmhtml sucks.

I can actually crash the gnome-help browser when I quit it after
viewing the 'run program' help files.

Comment 10 Kjartan Maraas 2002-01-10 07:12:11 UTC
Fixed it for me. I'll run some more tests. I agree that it's bad to
spend a large amount of time fixing gtk-xmhtml, and this is one of the
last crashes I know of in there so let's leave it...

For 2.0 there's a new help browser anyway
Comment 11 Wayne Schuller 2002-01-10 09:49:27 UTC
The patch worked! 

Does this mean I am bug-hero of the week!? :)

What did you think of my help-browser gtkhtml idea? 

Surely that would fix all these xmhtml bugs.

It's a serious problem that every gnome desktop out there now has such
a buggy help browser.

And there will be so many more users of gnome 1.4 in the next 2 years...

Even if Gnome 2 is out in 3-4 months, it will take a year or a year
and a half for most distributions to catch up...

So dodgy.
Comment 12 Wayne Schuller 2002-01-14 22:42:02 UTC
*** Bug 68667 has been marked as a duplicate of this bug. ***
Comment 13 Wayne Schuller 2002-01-15 00:59:07 UTC
*** Bug 51299 has been marked as a duplicate of this bug. ***
Comment 14 Wayne Schuller 2002-01-16 00:10:34 UTC
ok I am fairly happy that the two bugs fixed in this bug are probably
most of the gnome-help-browser crashes. (except BUG 9293 which seems
to have gone away).

I am very happy and do not care much about gnome-help-browser now. :)
Comment 15 Wayne Schuller 2002-01-21 00:34:35 UTC
*** Bug 68286 has been marked as a duplicate of this bug. ***
Comment 16 Wayne Schuller 2002-02-02 01:16:53 UTC
*** Bug 69276 has been marked as a duplicate of this bug. ***
Comment 17 Wayne Schuller 2002-02-07 03:27:19 UTC
*** Bug 69232 has been marked as a duplicate of this bug. ***
Comment 18 Wayne Schuller 2002-02-22 03:46:59 UTC
*** Bug 66109 has been marked as a duplicate of this bug. ***