After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 668776 - Plug some mem leaks
Plug some mem leaks
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2012-01-26 20:44 UTC by Cosimo Cecchi
Modified: 2012-01-27 10:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
housekeeping: plug a mem leak (933 bytes, patch)
2012-01-26 20:44 UTC, Cosimo Cecchi 		committed Details | Review
wacom: make sure to unref GnomeRRConfig and GnomeRROutputInfo (2.12 KB, patch)
2012-01-26 20:44 UTC, Cosimo Cecchi 		committed Details | Review
wacom: unref the variants we get with g_settings_get_value() (1.98 KB, patch)
2012-01-26 20:44 UTC, Cosimo Cecchi 		committed Details | Review
xsettings: plug a mem leak (998 bytes, patch)
2012-01-26 20:44 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2012-01-26 20:44:11 UTC 
I was running gnome-settings-daemon under valgrind today; it found *lots* of small leaks here and there. This is an attempt to fix some.
Comment 1 Cosimo Cecchi 2012-01-26 20:44:14 UTC 
Created attachment 206218 [details] [review]
housekeeping: plug a mem leak

Free the mount list, since it's transfer full.
Comment 2 Cosimo Cecchi 2012-01-26 20:44:16 UTC 
Created attachment 206219 [details] [review]
wacom: make sure to unref GnomeRRConfig and GnomeRROutputInfo

And ensure the output info stays alive even if we unref the config
before.
Comment 3 Cosimo Cecchi 2012-01-26 20:44:19 UTC 
Created attachment 206220 [details] [review]
wacom: unref the variants we get with g_settings_get_value()

Just let the set_* functions that take a GVariant also unref it.
Comment 4 Cosimo Cecchi 2012-01-26 20:44:22 UTC 
Created attachment 206221 [details] [review]
xsettings: plug a mem leak

Unref the variant we get from g_settings_get_value()
Comment 5 Bastien Nocera 2012-01-27 10:42:01 UTC 
All pushed, thanks very much!

Attachment 206218 [details] pushed as 4019549 - housekeeping: plug a mem leak
Attachment 206219 [details] pushed as 4c21d19 - wacom: make sure to unref GnomeRRConfig and GnomeRROutputInfo
Attachment 206220 [details] pushed as 152a5c4 - wacom: unref the variants we get with g_settings_get_value()
Attachment 206221 [details] pushed as 1b9d659 - xsettings: plug a mem leak