After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 668584 - Boxes doesn't work with latest gtk+ because of set_app_menu
Boxes doesn't work with latest gtk+ because of set_app_menu
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
3.3.x (unsupported)
Other Linux
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-01-24 15:02 UTC by Sebastian Keller
Modified: 2016-03-31 14:00 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Move set_app_menu to app.startup.connect_after (1.59 KB, patch)
2012-01-24 15:02 UTC, Sebastian Keller
accepted-commit_now Details | Review

Description Sebastian Keller 2012-01-24 15:02:54 UTC
Created attachment 205990 [details] [review]
Move set_app_menu to app.startup.connect_after

Boxes fails to start with a current git snapshot of gtk/glib because set_app_menu is not called from the app startup function.
This used to work when the menu stuff was still using dbus but broke when it switched to x properties.

Here is some non-committed documentation about this:
https://bugzilla.gnome.org/show_bug.cgi?id=668203

I'm attaching a patch that moves the menu to app startup. I've decided to put it into the startup directly as it was not part of setup_ui() before, but it might make sense to move it there (before creating the window).
Comment 1 Marc-Andre Lureau 2012-01-24 15:21:57 UTC
Review of attachment 205990 [details] [review]:

ack
Comment 2 Christophe Fergeau 2012-01-24 16:03:40 UTC
Pushed