After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 668541 - browser-plugin: plugin_enable_extension leaks invalid uuid
browser-plugin: plugin_enable_extension leaks invalid uuid
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.0.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-01-23 22:49 UTC by Owen Taylor
Modified: 2012-01-26 00:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
browser-plugin: Fix leak in plugin_enable_extension (939 bytes, patch)
2012-01-25 07:18 UTC, Jasper St. Pierre (not reading bugmail)
committed Details | Review

Description Owen Taylor 2012-01-23 22:49:24 UTC
plugin_enable_extension() needs to free the uuid when it's invalid.
Comment 1 Jasper St. Pierre (not reading bugmail) 2012-01-24 01:57:38 UTC
Were you going to attach a patch, or shall I?
Comment 2 Owen Taylor 2012-01-24 14:45:17 UTC
Wasn't going to attach a patch - just spotted it in review of browser-plugin changes.
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-01-25 07:18:22 UTC
Created attachment 206063 [details] [review]
browser-plugin: Fix leak in plugin_enable_extension
Comment 4 Owen Taylor 2012-01-25 16:55:13 UTC
Review of attachment 206063 [details] [review]:

Looks good
Comment 5 Jasper St. Pierre (not reading bugmail) 2012-01-26 00:04:17 UTC
Attachment 206063 [details] pushed as c6e924f - browser-plugin: Fix leak in plugin_enable_extension