After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 668504 - Make the WM to be aware of the g-c-c panel content
Make the WM to be aware of the g-c-c panel content
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-01-23 14:46 UTC by Marco Trevisan (Treviño)
Modified: 2012-01-23 15:14 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to change the WM_WINDOW_ROLE value when the g-c-c panel changes (1.07 KB, patch)
2012-01-23 14:46 UTC, Marco Trevisan (Treviño)
committed Details | Review

Description Marco Trevisan (Treviño) 2012-01-23 14:46:37 UTC
Created attachment 205886 [details] [review]
Patch to change the WM_WINDOW_ROLE value when the g-c-c panel changes

Window managers such as unity needs to know what panel gnome-control-center is currently showing. Changing the window role with the current panel ID should be the best practice to set a locale-independent value.

The attached patch fixes this issue.

See also launchpad bug #801784 http://pad.lv/801784
Comment 1 Bastien Nocera 2012-01-23 14:50:54 UTC
What's the purpose of this? We don't actually want the icon, or application name to change when changing panels. It should be referred to as "System Settings" even if you launched it as "Bluetooth Settings" for example.
Comment 2 Marco Trevisan (Treviño) 2012-01-23 14:53:28 UTC
Well, you maybe don't want this on Gnome Shell, but this just give the possibility to the WM to update these values.

Also because you're actually updating the window title and the window icon when the panel changes.
Comment 3 Bastien Nocera 2012-01-23 15:13:05 UTC
In the future, please attach a git-formatted patch, so I don't need
to include authorship myself.
Comment 4 Marco Trevisan (Treviño) 2012-01-23 15:14:35 UTC
Yes, you're right I should have used git... Thanks for committing it by the way. :)