Created attachment 205810 [details] [review]
Remove --build-optional-modules as it doesn't work

Attachment 205809 [details] needs to be applied first before this patch.

It does have some effect; but as it operates on <after> modules, and we don't have that many of them in the gnome modulesets, its effect is quite limited. Changing some <suggests> to <after> in gnome-apps-3.4 (in gupnp-dlna), I get the following proof:

$ jhbuild -m gnome-apps-3.4 list --list-optional-modules | wc -l
214
$ jhbuild -m gnome-world-3.4 list | wc -l
216
$ jhbuild -m gnome-world-3.4 list --list-optional-modules | wc -l
219

Ok, it has *some* effect, but what effect?

I added font-config as a fictitious after dep of glib.

# jhbuild list glib
gnome-common
intltool
gnome-doc-utils
gtk-doc
glib

# jhbuild list glib --list-optional-modules
gnome-common
intltool
gnome-doc-utils
gtk-doc
glib

Works for me (using fontconfig, not font-config):

gnome-common
intltool
rarian
gnome-doc-utils
gtk-doc
expat
fontconfig
glib

Other tests regarding glib could fail on the dependency circle handling (this is why shared-mime-info is not mentioned on jhbuild list glib --list-optional-modules)

For a simple example:

  <metamodule id="a">
    <after>
      <dep package="b"/>
    </after>
  </metamodule>

  <metamodule id="b">
  </metamodule>

Will build b then a, if optional modules are requested.

Thanks Frédéric, I understand what is happening now. I've implemented what I've learnt in bug 669554.