After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 668305 - location-controller: use the right signal data to unblock signal
location-controller: use the right signal data to unblock signal
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-01-19 22:11 UTC by Cosimo Cecchi
Modified: 2012-01-20 03:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
location-controller: use the right signal data to unblock signal (1.31 KB, patch)
2012-01-19 22:11 UTC, Cosimo Cecchi 		accepted-commit_now Details | Review
location-controller: remove references to "proxy" (2.27 KB, patch)
2012-01-19 22:13 UTC, Cosimo Cecchi 		accepted-commit_now Details | Review

Description Cosimo Cecchi 2012-01-19 22:11:37 UTC 
Fix for a regression of the refactoring of EphyLocationEntry/EphyLocationAction
Comment 1 Cosimo Cecchi 2012-01-19 22:11:39 UTC 
Created attachment 205661 [details] [review]
location-controller: use the right signal data to unblock signal

We were using priv->proxy, which is a leftover from when this was a
GtkAction, and is actually always NULL. Use the right pointer instead.
Fix location entry failing to properly update the address when switching
tabs.
Comment 2 Cosimo Cecchi 2012-01-19 22:13:57 UTC 
Created attachment 205663 [details] [review]
location-controller: remove references to "proxy"

We're not a GtkAction anymore, so referencing "proxy" in the code is a
bit misleading.
Comment 3 Xan Lopez 2012-01-20 00:19:54 UTC 
Review of attachment 205661 [details] [review]:

Good catch.
Comment 4 Xan Lopez 2012-01-20 00:20:29 UTC 
Review of attachment 205663 [details] [review]:

OK.
Comment 5 Cosimo Cecchi 2012-01-20 03:48:27 UTC 
Pushed these to master