After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 668103 - Comment popup doesn't close
Comment popup doesn't close
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: GUI
1.10.x
Other Linux
: Normal normal
: ---
Assigned To: Jean Bréfort
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2012-01-17 15:43 UTC by S
Modified: 2014-03-15 10:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (3.61 KB, patch)
2012-01-28 09:28 UTC, Jean Bréfort 		rejected Details | Review

Description S 2012-01-17 15:43:24 UTC 
Using Gnumeric 1.10.17 on latest Ubuntu.

1. Open new workbook.
2. Enter comment in cell.
3. Move mouse over comment; popup appears.
4. Change sheet using Ctrl-PageUp/Down.
5. Comment popup doesn't close. It remains open and on top even when changing applications.
6. Comment popup closes only if you go back to the original sheet and comment and move over comment with the mouse.

Regards
Soeren

PS: If this has already been fixed in the development version, is it correct to assume that lots of these GUI bugs are already fixed and there is no need for further bug reports for now?
Comment 1 Andreas J. Guelzow 2012-01-17 16:02:38 UTC 
I can observe both 
1) failure to close the popup when changing sheets and
2) failure to close the popup when changing applications (with alt-tab)

(1) is clearly a Gnumeric problem. My first reaction is that (2) is not.

Note that we can never say anything about unreported bugs. So having one fixed already does not say anything about potential others.
Comment 2 Jean Bréfort 2012-01-23 16:59:00 UTC 
Worse, clicking on the popup after alt-tab crashes gnumeric. Might be a different issue though.
Comment 3 Andreas J. Guelzow 2012-01-23 17:12:36 UTC 
I suspect the crash has nothing really to do with the alt-tab otehr than that it allows one to click in the popup which isn't possible under normal circumstances:

+ Trace 229499

  • #0 gtk_text_layout_set_cursor_visible
    at /build/buildd/gtk+3.0-3.2.0/./gtk/gtktextlayout.c line 525
  • #1 gtk_text_view_check_cursor_blink
    at /build/buildd/gtk+3.0-3.2.0/./gtk/gtktextview.c line 5198
  • #2 gtk_text_view_start_selection_drag
    at /build/buildd/gtk+3.0-3.2.0/./gtk/gtktextview.c line 6533
  • #3 gtk_text_view_start_selection_drag
    at /build/buildd/gtk+3.0-3.2.0/./gtk/gtktextview.c line 6467
  • #4 gtk_text_view_button_press_event
    at /build/buildd/gtk+3.0-3.2.0/./gtk/gtktextview.c line 4615
  • #5 _gtk_marshal_BOOLEAN__BOXED
    at /build/buildd/gtk+3.0-3.2.0/./gtk/gtkmarshalers.c line 85
  • #6 ??
    from /usr/lib/i386-linux-gnu/libgobject-2.0.so.0
  • #7 g_closure_invoke
    from /usr/lib/i386-linux-gnu/libgobject-2.0.so.0
  • #8 ??
    from /usr/lib/i386-linux-gnu/libgobject-2.0.so.0
  • #9 g_signal_emit_valist
    from /usr/lib/i386-linux-gnu/libgobject-2.0.so.0
  • #10 g_signal_emit
    from /usr/lib/i386-linux-gnu/libgobject-2.0.so.0
  • #11 gtk_widget_event_internal
    at /build/buildd/gtk+3.0-3.2.0/./gtk/gtkwidget.c line 6132
  • #12 gtk_propagate_event
    at /build/buildd/gtk+3.0-3.2.0/./gtk/gtkmain.c line 2629
  • #13 gtk_main_do_event
    at /build/buildd/gtk+3.0-3.2.0/./gtk/gtkmain.c line 1894
  • #14 _gdk_event_emit
    at /build/buildd/gtk+3.0-3.2.0/./gdk/gdkevents.c line 71
  • #15 gdk_event_source_dispatch
    at /build/buildd/gtk+3.0-3.2.0/./gdk/x11/gdkeventsource.c line 360
  • #16 g_main_context_dispatch
    from /lib/i386-linux-gnu/libglib-2.0.so.0
  • #17 ??
    from /lib/i386-linux-gnu/libglib-2.0.so.0
  • #18 g_main_loop_run
    from /lib/i386-linux-gnu/libglib-2.0.so.0
  • #19 gtk_main
    at /build/buildd/gtk+3.0-3.2.0/./gtk/gtkmain.c line 1367
  • #20 main
    at main-application.c line 376 

Note that there doesn't seem to be any Gnumeric code involved directly.
Comment 4 Jean Bréfort 2012-01-23 17:25:07 UTC 
Yes, the crash is a gtk+ bug. For the sheet change, we should be able to fix that easily, I suppose.
Comment 5 Morten Welinder 2012-01-23 18:34:23 UTC 
Do we have a bug number for the gtk+ part?
Comment 6 Jean Bréfort 2012-01-28 07:37:40 UTC 
The failure to close the popup when changing application is a gnumeric bug. The popup window is not linked to the main gnumeric window, except it has the same screen.
I tried to fix the issue using gtk_widget_set_tooltip_window with minimal changes, but it does not work (the popup window never becomes visible).
Comment 7 Jean Bréfort 2012-01-28 09:28:46 UTC 
Created attachment 206313 [details] [review]
Proposed patch

Seems this patch works.
Comment 8 Jean Bréfort 2014-03-15 10:43:53 UTC 
Comment on attachment 206313 [details] [review]
Proposed patch

We can just use the leave_notify event.
Comment 9 Jean Bréfort 2014-03-15 10:49:52 UTC 
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.