After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 668092 - x264enc: Fix handling of downstream GstForceKeyUnit events
x264enc: Fix handling of downstream GstForceKeyUnit events
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-ugly
unspecified
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 668094
 
 
Reported: 2012-01-17 14:02 UTC by Andoni Morales
Modified: 2013-01-21 19:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix handling of GstForceKeyUnitEvents (2.58 KB, patch)
2012-01-17 14:02 UTC, Andoni Morales 		none Details | Review
Fix handling of GstForceKeyUnit downstream events (5.03 KB, patch)
2012-01-31 11:51 UTC, Andoni Morales 		none Details | Review
Fix handling of GstForceKeyUnit downstream events (5.03 KB, patch)
2012-01-31 11:52 UTC, Andoni Morales 		none Details | Review
Fix handling of GstForceKeyUnit downstream events (5.36 KB, patch)
2012-01-31 12:11 UTC, Andoni Morales 		none Details | Review

Description Andoni Morales 2012-01-17 14:02:40 UTC 
Created attachment 205445 [details] [review]
Fix handling of GstForceKeyUnitEvents

Don't forward the event directly, but store and forward it before the next IDR.
Comment 1 Andoni Morales 2012-01-31 11:51:05 UTC 
Created attachment 206510 [details] [review]
Fix handling of GstForceKeyUnit downstream events

Update patch with last upstream changes
Comment 2 Andoni Morales 2012-01-31 11:52:56 UTC 
Created attachment 206511 [details] [review]
Fix handling of GstForceKeyUnit downstream events

Fix typo
Comment 3 Andoni Morales 2012-01-31 12:11:31 UTC 
Created attachment 206512 [details] [review]
Fix handling of GstForceKeyUnit downstream events

And dispose the pending event properly.
Comment 4 Andoni Morales 2012-08-24 16:21:20 UTC 
ping?
Comment 5 Olivier Crête 2012-08-24 16:53:35 UTC 
Is this still relevant after the port to the GstVideoEncoder base class ?
Comment 6 Andoni Morales 2012-08-24 17:07:15 UTC 
It's probably now outdated after the port to the encoder base classes. I was reviewing old bugs :)
I will check again
Comment 7 Olivier Crête 2013-01-21 19:32:43 UTC 
As Andoni said, base classes handle it now.. Re-open if something is still broken