Created attachment 205437 [details] [review]
Fix timeout callback leaks

Make sure that we don't leak oneshot timeout handlers in main.js and
polkitAuthenticationAgent.js by making the callback return false.

Review of attachment 205437 [details] [review]:

Makes sense

Attachment 205437 [details] pushed as 3f32846 - Fix timeout callback leaks

This is a good cleanup, but i don't think actually fixes a leak - the return of a javascript function without an explicit return statement is the undefined value which is boolean false.

(In reply to comment #4)
> This is a good cleanup, but i don't think actually fixes a leak - the return of
> a javascript function without an explicit return statement is the undefined
> value which is boolean false.

Ah OK, that makes sense. I spotted the first one while reading _windowRemoved but wasn't sure what the "default return value" would be. But yeah undefined and thus false makes sense.