After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 668081 - Wrong playbin2 doc about DVD URIs
Wrong playbin2 doc about DVD URIs
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other All
: Normal minor
: 0.10.37
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-01-17 09:56 UTC by Olivier Aubert
Modified: 2012-03-04 20:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
git patch for playbin2 doc (2.37 KB, patch)
2012-01-17 09:56 UTC, Olivier Aubert
none Details | Review

Description Olivier Aubert 2012-01-17 09:56:16 UTC
Created attachment 205431 [details] [review]
git patch for playbin2 doc

The playbin2 documentation needs some modification: about DVD support, it states that "In future ways might be added to specify the device as part of the URI, but at the time of writing this is not possible yet." and gives as example 

"gst-launch -v playbin uri=dvd://1

This will play back title 1 of a DVD in your disc drive (assuming the drive is detected automatically by the plugin)."

However, the resindvd element uses the following syntax: dvd://[path/to/device]. Then, both the explanation and the example are wrong. Running the example code will not work, since there is (usually) no DVD device named "1".

Side remark: the command line examples given in the playbin2 page http://gstreamer.freedesktop.org/data/doc/gstreamer/head/gst-plugins-base-plugins/html/gst-plugins-base-plugins-playbin2.html use playbin as element.

The attached git patch addresses these issues.
Comment 1 Tim-Philipp Müller 2012-02-15 12:08:15 UTC
If that URI scheme is accepted, depends a lot on the plugin installed. It will work with resindvd, but not with dvdreadsrc, for example. Hence left the original blurb there, slightly modified.

commit c79d2d314c019221f121d0842240c3153da5bdf0
Author: Olivier Aubert <olivier.aubert@liris.cnrs.fr>
Date:   Tue Jan 17 10:54:48 2012 +0100

    docs: fix playbin2 documentation about DVD URIs
    
    and playbin => playbin2 in example pipelines.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=668081
Comment 2 Olivier Aubert 2012-02-15 14:45:38 UTC
Wouldn't the 1.0 release be the right time to settle on a common syntax for DVD URIs for all DVD-related plugins? It would solve this issue, and most importantly avoid that playbin users have to care about the underlying plugin.

It is in fact related to #668083 which  is tagged on [resindvd] but would apply equally to any DVD plugin.
Comment 3 Stefan Sauer (gstreamer, gtkdoc dev) 2012-03-04 20:56:52 UTC
yes, patches welcome.