After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 667859 - check default connection is there before crashing badly
check default connection is there before crashing badly
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-01-13 11:27 UTC by Marc-Andre Lureau
Modified: 2016-03-31 13:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
check default connection is there before crashing badly (931 bytes, patch)
2012-01-13 11:27 UTC, Marc-Andre Lureau 		none Details | Review
check default connection is there before crashing badly (1.01 KB, patch)
2012-01-13 11:32 UTC, Marc-Andre Lureau 		none Details | Review
check default connection is there before crashing badly, (3.38 KB, patch)
2012-01-13 13:04 UTC, Marc-Andre Lureau 		accepted-commit_now Details | Review
The app need to switch too to Wizard state (779 bytes, patch)
2012-01-13 13:04 UTC, Marc-Andre Lureau 		accepted-commit_now Details | Review

Description Marc-Andre Lureau 2012-01-13 11:27:47 UTC 
Recent change now makes boxes crash if there is no default connection
Comment 1 Marc-Andre Lureau 2012-01-13 11:27:49 UTC 
Created attachment 205178 [details] [review]
check default connection is there before crashing badly
Comment 2 Marc-Andre Lureau 2012-01-13 11:32:33 UTC 
Created attachment 205179 [details] [review]
check default connection is there before crashing badly
Comment 3 Marc-Andre Lureau 2012-01-13 11:49:21 UTC 
ok that doesn't work reliably.. we need something better..
Comment 4 Marc-Andre Lureau 2012-01-13 13:04:09 UTC 
Created attachment 205184 [details] [review]
check default connection is there before crashing badly,

And wait until the default connection is ready before proceeding
with installer etc..
Comment 5 Marc-Andre Lureau 2012-01-13 13:04:19 UTC 
Created attachment 205185 [details] [review]
The app need to switch too to Wizard state
Comment 6 Marc-Andre Lureau 2012-01-13 16:29:09 UTC 
Review of attachment 205184 [details] [review]:

::: src/app.vala
@@ +221,3 @@
+        if (default_connection == null) {
+            printerr ("error: missing or failing default libvirt connection");
+        } catch (GLib.Error error) {

I'll add return; here, just to avoid unecessary background work
Comment 7 Zeeshan Ali 2012-01-13 17:15:40 UTC 
Review of attachment 205184 [details] [review]:

Looks good, ACK!
Comment 8 Zeeshan Ali 2012-01-13 17:16:43 UTC 
Review of attachment 205185 [details] [review]:

ACK! This wouldn't happen if we always used 'this'. :)
Comment 9 Marc-Andre Lureau 2012-01-16 17:23:22 UTC 
pushed now (forgot the bz)