After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 667848 - rtpsession: Add thread safe method to retrieve sdes and stats from source.
rtpsession: Add thread safe method to retrieve sdes and stats from source.
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other All
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-01-13 09:22 UTC by Pascal Buhler
Modified: 2018-11-03 14:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (7.80 KB, patch)
2012-01-13 09:22 UTC, Pascal Buhler 		none Details | Review

Description Pascal Buhler 2012-01-13 09:22:49 UTC 
Created attachment 205169 [details] [review]
patch

The previous way of retrieving stats/sdes was by first getting a ref to the rtpsource and then querying the property on the source. That is unsafe as there are no locks in rtpsource, the rtpsession needs to be locked. So add accessible function to access the properties of the rtpsource through the rtpsession.
Comment 1 Olivier Crête 2013-01-28 22:18:14 UTC 
Pascal is raising a very good point, we should probably deprecate the rtpsource exposing API with a big fat warning and expose a safer API. The probation property on the source should also be made safer somehow also.

I also still think that having to fish out the rtpsession from the rtpbin is a pretty terrible API for the stats, we should have something on rtpbin.
Comment 2 Olivier Crête 2018-05-04 12:14:15 UTC 
This bug is still valid... But no one else has complained in years. Is someone using something similar? Havard: Are you using this at pexip?
Comment 3 GStreamer system administrator 2018-11-03 14:45:14 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/issues/54.