After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 667730 - Add Since: to gdk_x11_device_get_id(), gdk_x11_device_manager_lookup(), gdk_x11_window_set_utf8_property() docs
Add Since: to gdk_x11_device_get_id(), gdk_x11_device_manager_lookup(), gdk_x...
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: X11
3.3.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2012-01-12 04:22 UTC by Alexandre Rostovtsev
Modified: 2012-03-18 14:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch for gtk+ git master (3.3.x) (1.65 KB, patch)
2012-01-12 04:24 UTC, Alexandre Rostovtsev 		accepted-commit_now Details | Review
Proposed patch for gtk+ gtk-3-2 branch (1.12 KB, patch)
2012-01-12 04:25 UTC, Alexandre Rostovtsev 		accepted-commit_now Details | Review

Description Alexandre Rostovtsev 2012-01-12 04:22:32 UTC 
gdk_x11_device_get_id() and gdk_x11_device_manager_lookup() were added in 3.1.10; gdk_x11_window_set_utf8_property() was added in 3.3.6. Currently, all of these functions lack a "Since:" declaration in their documentation, and then people assume that these functions had been there always, and bugs like https://bugs.gentoo.org/show_bug.cgi?id=398589 result.
Comment 1 Alexandre Rostovtsev 2012-01-12 04:24:33 UTC 
Created attachment 205057 [details] [review]
Proposed patch for gtk+ git master (3.3.x)
Comment 2 Alexandre Rostovtsev 2012-01-12 04:25:21 UTC 
Created attachment 205058 [details] [review]
Proposed patch for gtk+ gtk-3-2 branch
Comment 3 Matthias Clasen 2012-01-15 19:19:07 UTC 
Review of attachment 205057 [details] [review]:

Thanks, looks fine
Comment 4 Matthias Clasen 2012-01-15 19:19:23 UTC 
Review of attachment 205058 [details] [review]:

Please commit, thanks
Comment 5 André Klapper 2012-02-22 11:57:39 UTC 
Alexandre: Can you commit this, please?
Comment 6 Alexandre Rostovtsev 2012-02-22 13:30:25 UTC 
(In reply to comment #5)
> Alexandre: Can you commit this, please?

No. I do not have gnome commit access.
Comment 7 André Klapper 2012-03-09 16:10:31 UTC 
I see... Can somebody commit this please?
Comment 8 Matthias Clasen 2012-03-18 14:42:01 UTC 
All the Since tags are already in place now