After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 667694 - Support Call1 channels
Support Call1 channels
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: telepathy
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Shell Telepathy maintainer(s)
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-01-11 12:57 UTC by Xavier Claessens
Modified: 2012-02-21 16:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Support only Call1 channels (2.69 KB, patch)
2012-01-11 12:57 UTC, Xavier Claessens 		needs-work Details | Review
Support only Call1 channels (2.95 KB, patch)
2012-02-21 16:32 UTC, Guillaume Desmottes 		reviewed Details | Review
Support only Call1 channels (3.39 KB, patch)
2012-02-21 16:44 UTC, Guillaume Desmottes 		committed Details | Review

Description Xavier Claessens 2012-01-11 12:57:19 UTC 
We are moving away from StreamedMedia and Call.DRAFT in all telepathy modules. The new spec is Call1.

Here is a fix, it should wait for empathy to handle Call1 as well.

http://cgit.collabora.com/git/user/xclaesse/gnome-shell.git/log/?h=call1
Comment 1 Xavier Claessens 2012-01-11 12:57:44 UTC 
Created attachment 205019 [details] [review]
Support only Call1 channels
Comment 2 Owen Taylor 2012-01-26 20:22:17 UTC 
Review of attachment 205019 [details] [review]:

Can you fix the commit message to give an explanation about this change
What is the affect on the required Telepathy/Empathy versions?
Comment 3 Guillaume Desmottes 2012-02-21 16:32:14 UTC 
Created attachment 208149 [details] [review]
Support only Call1 channels

Empathy uses to support 2 D-Bus API for calls:
- StreamedMedia: legacy API
- Call.DRAFT: experimental version of the new API

Since 3.3.90, Empathy only support Call1, the first stable version of the new
API so the Shell should do the same.
Comment 4 Owen Taylor 2012-02-21 16:39:42 UTC 
Review of attachment 208149 [details] [review]:

Does this need a bump of TELEPATHY_GLIB_MIN_VERSION in configure.ac?

Grammar nits:

Since 3.3.90, Empathy only support Call1, 
                           ^^^^^^^
                           supports

the first stable version of the new API so the Shell should do the same.
                                       ^ add a ,
Comment 5 Guillaume Desmottes 2012-02-21 16:44:15 UTC 
Created attachment 208152 [details] [review]
Support only Call1 channels

Empathy uses to support 2 D-Bus API for calls:
- StreamedMedia: legacy API
- Call.DRAFT: experimental version of the new API

Since 3.3.90, Empathy only supports Call1, the first stable version of the new
API, so the Shell should do the same.
Comment 6 Guillaume Desmottes 2012-02-21 16:45:02 UTC 
(In reply to comment #4)
> Review of attachment 208149 [details] [review]:
> 
> Does this need a bump of TELEPATHY_GLIB_MIN_VERSION in configure.ac?

Indeed, sorry I forgot.
Comment 7 Owen Taylor 2012-02-21 16:45:51 UTC 
Review of attachment 208152 [details] [review]:

Looks good
Comment 8 Guillaume Desmottes 2012-02-21 16:48:03 UTC 
Attachment 208152 [details] pushed as f248aa6 - Support only Call1 channels