After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 667534 - Non-XInput2 build fix
Non-XInput2 build fix
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: X11
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2012-01-09 11:34 UTC by Patrick Welche
Modified: 2012-01-10 13:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
trivial build fix for non-XInput2 systems (1.04 KB, patch)
2012-01-09 11:34 UTC, Patrick Welche 		accepted-commit_now Details | Review

Description Patrick Welche 2012-01-09 11:34:46 UTC 
Created attachment 204856 [details] [review]
trivial build fix for non-XInput2 systems

The  result of http://mail.gnome.org/archives/gtk-list/2012-January/msg00028.html

    The part in gdkwindow-x11.c which uses XIEvent and friends is "protected"
    by HAVE_XGENERICEVENTS, i.e., XGetEventData() has been found. (Xlib.h)
    
    XIEvent and friends are defined in <X11/extension/XInput2.h> which is
    included by gdkdisplay-x11.h if XINPUT_2 is defined.
    
    The patch makes sure XIEvent is only used if XINPUT_2 is defined.

I haven't tested this on with-and-with XInput2 systems - but I think it is obvious!
Comment 1 Carlos Garnacho 2012-01-09 12:50:56 UTC 
Review of attachment 204856 [details] [review]:

XIEvent must indeed be protected by defined(XINPUT_2). Looks good to me
Comment 2 Patrick Welche 2012-01-10 13:56:52 UTC 
commited as
http://git.gnome.org/browse/gtk+/commit/?id=2ceb092afca29e6da870c81a67e9049497652689

I take it that is the right thing to do when one sees "accepted-commit_now" ?