After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 667378 - hotplug-sniffer: fix double free when setting D-Bus return value
hotplug-sniffer: fix double free when setting D-Bus return value
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-01-05 19:40 UTC by Owen Taylor
Modified: 2012-01-16 23:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
hotplug-sniffer: fix double free when setting D-Bus return value (1.79 KB, patch)
2012-01-05 19:40 UTC, Owen Taylor 		reviewed Details | Review

Description Owen Taylor 2012-01-05 19:40:33 UTC 
See https://bugzilla.redhat.com/show_bug.cgi?id=743631
Comment 1 Owen Taylor 2012-01-05 19:40:36 UTC 
Created attachment 204705 [details] [review]
hotplug-sniffer: fix double free when setting D-Bus return value

g_dbus_method_invocation_return_value() adopts a floating reference,
so we don't also need to unreference it; fix by replacing the code
using a more compact form using the ^ convenience character in
GVariant type specifications. (Thanks to Ryan Lortie for the
suggestion.)
Comment 2 Colin Walters 2012-01-05 20:05:08 UTC 
Review of attachment 204705 [details] [review]:

Looks fine, but you should also add a link to the Red Hat bug which has the real-world triggering crash data.
Comment 3 Owen Taylor 2012-01-16 23:35:08 UTC 
Fix pushed (sorry, forget to update the commit message, but the link to the RH bug is here)