After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 667371 - power icon not updating properly
power icon not updating properly
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-01-05 17:24 UTC by Matthias Clasen
Modified: 2012-01-29 22:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
power: Emit GDBusProxy-compatible PropertiesChanged signal (7.90 KB, patch)
2012-01-05 20:24 UTC, Florian Müllner 		none Details | Review
power: Fix icon updates (1.40 KB, patch)
2012-01-29 21:25 UTC, Florian Müllner 		committed Details | Review

Description Matthias Clasen 2012-01-05 17:24:54 UTC 
Using gnome-shell 3.3.2 in rawhide, I notice that the power icon does not seem to reliably track the actual state of my system anymore. Sometimes it stays as charging after I undocked, sometimes I get the 'low power beep' from gsd even though the icon shows 100%, things like that.

Might be fallout from the gdbus porting ?
Comment 1 Florian Müllner 2012-01-05 20:24:53 UTC 
Created attachment 204708 [details] [review]
power: Emit GDBusProxy-compatible PropertiesChanged signal

(In reply to comment #0)
> Might be fallout from the gdbus porting ?

Yes. I'm attaching a g-s-d patch from Colin which fixed the problem for me, we should probably reassign the bug.
Comment 2 Matthias Clasen 2012-01-06 03:27:11 UTC 
Ok, moving to g-s-d
Comment 3 Bastien Nocera 2012-01-25 12:34:09 UTC 
Why can't gnome-shell listen to the Changed signal instead? If there's a code reason, I'd like to see the blocker bugs updated. Otherwise, update your properties yourself...
Comment 4 Bastien Nocera 2012-01-25 12:50:18 UTC 
Committed slightly modified. I removed the old interface, as one shouldn't
really mix'n'match environments, and added the origin of the signal.

Attachment 204708 [details] pushed as 07b1ed6 - power: Emit GDBusProxy-compatible PropertiesChanged signal
Comment 5 Florian Müllner 2012-01-29 21:24:58 UTC 
Reopening, as the icon still doesn't update (it's now a shell problem though, so reassigning as well).
Comment 6 Florian Müllner 2012-01-29 21:25:59 UTC 
Created attachment 206377 [details] [review]
power: Fix icon updates

gnome-settings-daemon commit 07b1ed63016 removed the custom 'Changed'
DBus signal in favor of the standard 'PropertiesChanged' signal, so
use that instead to update the icon.
Comment 7 Jasper St. Pierre (not reading bugmail) 2012-01-29 22:16:56 UTC 
Review of attachment 206377 [details] [review]:

Well sure.
Comment 8 Florian Müllner 2012-01-29 22:22:23 UTC 
Attachment 206377 [details] pushed as 8bcbf30 - power: Fix icon updates