After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 667223 - dvdspu: cleanup debug code
dvdspu: cleanup debug code
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 0.10.24
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-01-03 21:57 UTC by Rob Clark
Modified: 2012-06-10 13:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
dvdspu: cleanup debug code (3.82 KB, patch)
2012-01-03 21:57 UTC, Rob Clark 		committed Details | Review

Description Rob Clark 2012-01-03 21:57:31 UTC 
Clean up debug code for drawing highlight rects which wasn't even
compiling previously.

Disabling it with an if(FALSE) rather than #if 0, so that it at least doesn't bitrot.  Although having a way to enable it at runtime might be nice.

patch attached
Comment 1 Rob Clark 2012-01-03 21:57:53 UTC 
Created attachment 204530 [details] [review]
dvdspu: cleanup debug code
Comment 2 Tim-Philipp Müller 2012-06-10 13:32:26 UTC 
commit c372f2c88cc4cfd0cb9a8fab715dad55b9eb2405
Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
Date:   Sun Jun 10 14:29:58 2012 +0100

    dvdspu: allow debugging of render and highlight rectangles via environment variable
    
    Enable debugging of rectangles via GST_DVD_SPU_DEBUG.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=667223

commit 126df2548ded01f33ce2a489b6bf6f8d117c19ef
Author: Rob Clark <rob@ti.com>
Date:   Sat Dec 31 18:35:40 2011 -0600

    dvdspu: cleanup debug code
    
    Clean up debug code for drawing highlight rects which wasn't even
    compiling previously.
    
    TODO: might be nice if this could be controlled by properties or
    env variables to make it possible to enable the debug code at
    runtime.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=667223