After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 667218 - videoparsers: set interlaced field in caps for mpeg2
videoparsers: set interlaced field in caps for mpeg2
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 0.10.24
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-01-03 21:46 UTC by Rob Clark
Modified: 2012-01-31 11:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
videoparsers: set interlaced field in caps for mpeg2 (946 bytes, patch)
2012-01-03 21:46 UTC, Rob Clark 		committed Details | Review

Description Rob Clark 2012-01-03 21:46:11 UTC 
mpegvideoparse (in -bad/gst/videoparsers) wasn't setting interlaced field in caps.

patch attached
Comment 1 Rob Clark 2012-01-03 21:46:57 UTC 
Created attachment 204525 [details] [review]
videoparsers: set interlaced field in caps for mpeg2
Comment 2 Vincent Penquerc'h 2012-01-18 10:17:34 UTC 
Patch does not apply on latest git, but this one (against yours) does.
Can you confirm that's what was intended ?


diff --git a/gst/videoparsers/gstmpegvideoparse.c b/gst/videoparsers/gstmpegvideoparse.c
index bcd0505..8d19046 100644
--- a/gst/videoparsers/gstmpegvideoparse.c
+++ b/gst/videoparsers/gstmpegvideoparse.c
@@ -675,7 +675,7 @@ gst_mpegv_parse_update_src_caps (GstMpegvParse * mpvparse)
       GST_DEBUG_OBJECT (mpvparse, "Invalid level - %u", level_c);
 
     gst_caps_set_simple (caps, "interlaced",
-        G_TYPE_BOOLEAN, !mpvparse->params.progressive, NULL);
+        G_TYPE_BOOLEAN, !mpvparse->sequenceext.progressive, NULL);
   }
 
   gst_pad_set_caps (GST_BASE_PARSE_SRC_PAD (mpvparse), caps);
Comment 3 Rob Clark 2012-01-18 20:43:34 UTC 
I guess params was renamed to sequenceext.. or split up based on what nal contains the info (so sequenceext would make sense to me)
Comment 4 Vincent Penquerc'h 2012-01-31 11:52:46 UTC 
Pushed with that change, then. Thanks.

commit 521e8b199bc3c88b8cd902e236bf37d5485d6624
Author: Rob Clark <rob@ti.com>
Date:   Mon Dec 26 21:57:48 2011 -0600

    videoparsers: set interlaced field in caps for mpeg2
    
    https://bugzilla.gnome.org/show_bug.cgi?id=667218