Created attachment 204519 [details] [review]
link generate_sine_table against glib

Building gst-plugins-base-0.10.35 on x86_64-sun-solaris2.10 (not OpenSolaris) with the no-cost Sun/Oracle Workshop 12.2 compiler.

When building gst/videotestsrc/generate_sine_table, I get the following link error:

/bin/bash ../../libtool  --tag=CC   --mode=link cc -xipo=2 -xO4 -I/usr/X11/inclu
de -xc99=all -D_REENTRANT -D_PTHREADS -I/local/gnu/include/glib-2.0 -I/local/gnu
/lib/64/glib-2.0/include -D_REENTRANT -D_PTHREADS -I/local/gnu/include/gstreamer
-0.10 -I/local/gnu/include/glib-2.0 -I/local/gnu/lib/64/glib-2.0/include -I/loca
l/gnu/include/libxml2    -DG_THREADS_MANDATORY -DG_DISABLE_CAST_CHECKS -DG_DISAB
LE_ASSERT    -g    -Xa -xO4 -KPIC -xtarget=native -m64 -xarch=native -I/local/gn
u/include -I/local/gnu/include -I/local/include  -L/local/gnu/lib/64 -L/local/gn
u/lib/64 -L/local/lib/64 -o generate_sine_table generate_sine_table-generate_sin
e_table.o -lm -lnsl -lsocket 
libtool: link: cc -xipo=2 -xO4 -I/usr/X11/include -xc99=all -D_REENTRANT -D_PTHR
EADS -I/local/gnu/include/glib-2.0 -I/local/gnu/lib/64/glib-2.0/include -D_REENT
RANT -D_PTHREADS -I/local/gnu/include/gstreamer-0.10 -I/local/gnu/include/glib-2
.0 -I/local/gnu/lib/64/glib-2.0/include -I/local/gnu/include/libxml2 -DG_THREADS
_MANDATORY -DG_DISABLE_CAST_CHECKS -DG_DISABLE_ASSERT -g -Xa -xO4 -KPIC -xtarget
=native -m64 -xarch=native -I/local/gnu/include -I/local/gnu/include -I/local/in
clude -o generate_sine_table generate_sine_table-generate_sine_table.o  -L/local
/gnu/lib/64 -L/local/lib/64 -lm -lnsl -lsocket
Undefined           first referenced
 symbol                 in file
g_atomic_pointer_get                generate_sine_table-generate_sine_table.o
g_once_init_enter_impl              generate_sine_table-generate_sine_table.o
g_string_insert_c                   generate_sine_table-generate_sine_table.o
ld: fatal: Symbol referencing errors. No output written to generate_sine_table
gmake[4]: *** [generate_sine_table] Error 2
gmake[4]: Leaving directory `/local/src/RPM/BUILD/gst-plugins-base-0.10.35/gst/v
ideotestsrc'
gmake[3]: *** [all] Error 2
gmake[3]: Leaving directory `/local/src/RPM/BUILD/gst-plugins-base-0.10.35/gst/v



generate_sine_table is including <glib.h>, probably because it uses G_PI, and it's this inclusion of glib.h that is apparently generating a dependency on these glib-related routines.

The problem is that the Makefile is not set up to link generate_sine_table against glib.

I'm not certain this is the correct way to accomplish getting generate_sine_table linked against glib, but the following patch allows the link to succeed and the rest of the build to continue to completion.