GNOME Bugzilla – Bug 667009
Remove DRM vblank hack
Last modified: 2012-01-05 20:40:46 UTC
We probably want to upstream this patch http://pkgs.fedoraproject.org/gitweb/?p=cogl.git;a=blob;f=cogl-1.8.2-no-drm-hax.patch;h=e19a385bb6d7c70d45437bddb936d951a38dc0f0;hb=c6fc02e4b0d486c841556a3f5cc7d0b8dd5317f8 Drivers that require this (via) need lots of fixes to be useful anyway.
I agree. the DRM vblank was already a desperate fallback back in the days when we didn't know any better; any platform/GPU with which it may have worked it's not supporting GL in any meaningful way anyway. I think it's high time we kill that piece of code once and for all.
Yeah, thanks, I've landed this patch in master as: commit 3bc70687ac92b237febeb0f369394e8e6bea9d53 Author: Robert Bragg <robert@linux.intel.com> Date: Thu Jan 5 20:21:51 2012 +0000 Remove old fallback for vblank wait via manual drm ioctl This workaround code has just been incrementally carried forward since Cogl was integrated with Clutter but really we have no idea when this code path was ever tested. Since the work around is from before the time of the current Cogl developers we don't know anything about the circumstances which led to this extreme workaround instead of pushing to fix a driver. It seems pretty likely we can push to fix any drm based drivers so we're removing the workaround. https://bugzilla.gnome.org/show_bug.cgi?id=667009 Reviewed-by: Neil Roberts <neil@linux.intel.com>