After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 666600 - button: allocate the CSS border and deprecate GtkButton-inner-border
button: allocate the CSS border and deprecate GtkButton-inner-border
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2011-12-20 16:54 UTC by Cosimo Cecchi
Modified: 2011-12-20 18:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
button: add a border param to gtk_button_get_props() (2.47 KB, patch)
2011-12-20 16:54 UTC, Cosimo Cecchi 		committed Details | Review
button: add CSS borders to the size request (3.66 KB, patch)
2011-12-20 16:55 UTC, Cosimo Cecchi 		committed Details | Review
button: deprecate the inner-border style property (5.66 KB, patch)
2011-12-20 16:55 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2011-12-20 16:54:54 UTC 
See attached patchset; CSS borders should be allocated by GtkButton, and the content inside the button should be allocated inside the border box. GtkButton did the same with inner-border, which at this point can be deprecated and ignored.
Comment 1 Cosimo Cecchi 2011-12-20 16:54:57 UTC 
Created attachment 203963 [details] [review]
button: add a border param to gtk_button_get_props()

We'll use it later to compute the child offsets.
Comment 2 Cosimo Cecchi 2011-12-20 16:55:05 UTC 
Created attachment 203964 [details] [review]
button: add CSS borders to the size request

And allocate the button children according to it as well.
Comment 3 Cosimo Cecchi 2011-12-20 16:55:09 UTC 
Created attachment 203965 [details] [review]
button: deprecate the inner-border style property

Since we allocate the standard CSS border to the button now, and center
the child accordingly, there's no need for an additional inner-border
style property. Deprecate it and ignore its values.
Comment 4 Cosimo Cecchi 2011-12-20 18:09:33 UTC 
Attachment 203963 [details] pushed as fe59c5f - button: add a border param to gtk_button_get_props()
Attachment 203964 [details] pushed as 0021ef1 - button: add CSS borders to the size request
Attachment 203965 [details] pushed as 2827cd4 - button: deprecate the inner-border style property

Pushed to master.