GNOME Bugzilla – Bug 666411
Show vorbis DESCRIPTION in Comment field on Nautilus Audio Properties Tab
Last modified: 2011-12-21 21:19:20 UTC
Created attachment 203731 [details] [review] Quick copy and paste to demonstrate this - I expect it needs fixing. The Ogg Vorbis format specification, used also by flac http://flac.sourceforge.net/format.html#metadata_block_vorbis_comment recommended minimal tag name is DESCRIPTION http://xiph.org/vorbis/doc/v-comment.html and not COMMENT. Suggest totem could display DESCRIPTION in the Comment field on audio properties tab, if COMMENT does not exist. Currently Comment is empty for Vorbis format compliant flac files.
Review of attachment 203731 [details] [review]: Seems reasonable to me. Please polish your patch and then it can be committed. Thanks. ::: totem-3.2.1/src/totem-properties-view.c.orig @@ +75,3 @@ guint i; GDate *date; + GString *comment; This should be a gchar*. @@ +88,3 @@ } + + /* Comment */ Please expand this comment to reference either this bug report or the standards documents you linked to. @@ +95,1 @@ + string = g_strdup_printf ("%s", comment); No need for a strdup here. Ownership of the output from gst_tag_list_get_string() is transferred to the caller.
Created attachment 204060 [details] [review] Patch to totem Updated patch created against master and tested with 3.2.1.
Comment on attachment 204060 [details] [review] Patch to totem Great! Committed to master, thanks. commit b56e6a6e4a09d9c3efb768fef4330c4a9b95be16 Author: Chris Mayo <aklhfex@gmail.com> Date: Wed Dec 21 20:07:05 2011 +0000 properties: Show Vorbis DESCRIPTION in Comment Currently the Comment field is empty on Nautilus Audio Properties Tab for files with headers using the minimal list of names from the Vorbis format specification which uses DESCRIPTION: http://xiph.org/vorbis/doc/v-comment.html. Still prefer COMMENT but if that does not exist check for DESCRIPTION. https://bugzilla.gnome.org/show_bug.cgi?id=666411 Signed-off-by: Chris Mayo <aklhfex@gmail.com> src/totem-properties-view.c | 13 ++++++++++++- 1 files changed, 12 insertions(+), 1 deletions(-)