GNOME Bugzilla – Bug 666373
wizard: Present bootable ISO files
Last modified: 2016-03-31 13:54:56 UTC
Using Tracker (once bug#666372 has been fixed), we should provide a nice list of VM sources to choose from at 'Source' page of wizard so that user doesn't need to browse to the ISOs or write URI/path.
Created attachment 207422 [details] [review] wizard: Present bootable ISO files on 'Source' page This patch also makes fetching of media sources (both HW and ISO image) dynamic. Keeping all these points in mind: 1. For each addition/deletion signal you get integer ID against which you use a Sparql query to check what Tracker is talking about. i-e inefficient and redundant code. 2. Tracker doesn't send out any signal for ISO files by default, which makes it impossible to monitor ISO files. Hopefully this will be fixed when patches to add better support for bootable ISOs (bug#666372) are merged. 3. A typical user will not have >10 ISOs (?). 4. We cache the source widgets. I'm propose we do it this way.
(In reply to comment #1) > Created an attachment (id=207422) [details] [review] > wizard: Present bootable ISO files on 'Source' page NOTE: This patch does not require any unmerged patches to Tracker.
Now that bug#666372 has been fixed, I'll be providing another patch that makes use of the new Tracker properties so that we don't have to do any detection on ISOs at all. It'll still need bug#670023 though but I'm guessing that'll be resolved rather quickly.
Created attachment 207508 [details] [review] wizard: Present bootable ISO files on 'Source' page This patch also makes fetching of media sources (both HW and ISO image) dynamic. Keeping all these points in mind: 1. For each addition/deletion signal you get integer ID against which you use a Sparql query to check what Tracker is talking about. i-e inefficient and redundant code. 2. A typical user will not have >10 ISOs (?). 3. We cache the source widgets. I'm propose we do it this way.
Created attachment 207601 [details] [review] wizard: Present bootable ISO files on 'Source' page Since for each addition/deletion Tracker, you get an integer ID from Tracker against which you use a Sparql query to check what Tracker is talking about, the code to handle the these signals will be inefficient and unnecessarily complicated. So instead of keeping a list of medias (HW and ISO images), we now: 1. Asynchronously fetch list of medias on startup and create the widgets for them in the wizard. 2. When the 'Source' page of wizard is activated/shown, we refetch the list (again asynchronously) and add/remove widgets accordingly.
Created attachment 207607 [details] [review] wizard: Present bootable ISO files on 'Source' page Since for each addition/deletion Tracker, you get an integer ID from Tracker against which you use a Sparql query to check what Tracker is talking about, the code to handle the these signals will be inefficient and unnecessarily complicated. So instead of keeping a list of medias (HW and ISO images), we now: 1. Asynchronously fetch list of medias on startup and create the widgets for them in the wizard. 2. When the 'Source' page of wizard is activated/shown, we refetch the list (again asynchronously) and add/remove widgets accordingly.
Created attachment 207820 [details] [review] wizard: Present bootable ISO files on 'Source' page Same as the previous one except: * The redundant "Local Machine:.." label has been removed. * System title now in bold (as per jimmac's suggestion). * Reduced size of entries/icon by about half. * More padding. Looks like this: http://static.fi/~zeenix/tmp/boxes-small-iso-icons.png
Created attachment 207831 [details] [review] wizard: Present bootable ISO files on 'Source' page This version adds a label for media architecture (if known) as per jimmac's new mockup: https://github.com/gnome-design-team/gnome-mockups/raw/38e6701a3ad3c204cb7bea629dda97553b869eb8/boxes/boxes-install2.0.png Looks like this: http://static.fi/~zeenix/tmp/boxes-small-iso-icons+arch.png
Created attachment 207875 [details] [review] wizard: Present bootable ISO files on 'Source' page This version does a much better job at handling unknown (to libosinfo) ISOs.
So whats the verdict on this one?
Review of attachment 207875 [details] [review]: ack
Attachment 207875 [details] pushed as 02538bd - wizard: Present bootable ISO files on 'Source' page