After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 665960 - Tab popup should be able to be used without activating the tab
Tab popup should be able to be used without activating the tab
Status: RESOLVED FIXED
Product: gedit
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Gedit maintainers
Gedit maintainers
Depends on:
Blocks:
 
 
Reported: 2011-12-11 18:38 UTC by Ignacio Casal Quinteiro (nacho)
Modified: 2012-03-09 20:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
tab popup (15.14 KB, patch)
2011-12-11 18:38 UTC, Ignacio Casal Quinteiro (nacho) 		none Details | Review
tab popup v2 (22.15 KB, patch)
2011-12-14 07:45 UTC, Ignacio Casal Quinteiro (nacho) 		none Details | Review

Description Ignacio Casal Quinteiro (nacho) 2011-12-11 18:38:45 UTC 
Created attachment 203216 [details] [review]
tab popup

Well you know that I like to have things working properly. I attached a patch that makes this work like firefox.
Comment 1 Paolo Borelli 2011-12-11 21:19:48 UTC 
Review of attachment 203216 [details] [review]:

Patch looks ok to me, but I do not like the from_action names... what about leaving save/save_as as they are now and add new _gedit_cmd_tab_* functions for the popup menu?
Comment 2 Paolo Borelli 2011-12-11 21:21:56 UTC 
In fact we could move all the callbacks of the popup menu to a gedit-cmd-tab file so that window.c does not keep growing
Comment 3 Ignacio Casal Quinteiro (nacho) 2011-12-12 07:33:07 UTC 
If we want to move code away we could just go for a GeditNotebookPopupMenu class and get rid of all the popup menu stuff.
Comment 4 Ignacio Casal Quinteiro (nacho) 2011-12-14 07:45:21 UTC 
Created attachment 203423 [details] [review]
tab popup v2

With the new class
Comment 5 Ignacio Casal Quinteiro (nacho) 2012-03-09 20:54:33 UTC 
I actually fixed this already.