After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 665224 - [0.11] [matroska]crashes on empty laces
[0.11] [matroska]crashes on empty laces
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
0.11.x
Other Mac OS
: Normal major
: 0.11.x
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-11-30 17:13 UTC by Matej Knopp
Modified: 2012-01-24 14:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Skip empty lace (939 bytes, patch)
2011-11-30 17:13 UTC, Matej Knopp 		needs-work Details | Review
Patch (828 bytes, patch)
2011-12-01 14:52 UTC, Matej Knopp 		committed Details | Review

Description Matej Knopp 2011-11-30 17:13:14 UTC 
Created attachment 202463 [details] [review]
Skip empty lace

When the demuxed encounter lace with size 0 it crashes. Patch prints warning and skips the lace
Comment 1 Sebastian Dröge (slomo) 2011-12-01 09:14:36 UTC 
Comment on attachment 202463 [details] [review]
Skip empty lace

This patch is wrong, empty laces are valid and could happen with theora for example (which allows 0-byte packets). Instead the copying below these lines shouldn't be done for empty laces.
Comment 2 Matej Knopp 2011-12-01 14:51:46 UTC 
Thanks for feedback. I'll attach another patch that moves the check deeper to gst_matroska_demux_check_subtitle_buffer where the crash actually happens.
Comment 3 Matej Knopp 2011-12-01 14:52:28 UTC 
Created attachment 202524 [details] [review]
Patch
Comment 4 Vincent Penquerc'h 2012-01-24 14:12:59 UTC 
commit b780639b2cc6dd9e61f18eadb9f0967aa2f1c3da
Author: Matej Knopp <matej.knopp@gmail.com>
Date:   Thu Dec 1 15:49:40 2011 +0100

    Don't crash on empty laces
    
    https://bugzilla.gnome.org/show_bug.cgi?id=665224