After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 664851 - Load _DBUS_APPLICATION_ID property, expose it via API
Load _DBUS_APPLICATION_ID property, expose it via API
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks: 621203
 
 
Reported: 2011-11-25 23:43 UTC by Colin Walters
Modified: 2011-12-15 15:13 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Load _DBUS_APPLICATION_ID property, expose it via API (6.07 KB, patch)
2011-11-25 23:43 UTC, Colin Walters
committed Details | Review

Description Colin Walters 2011-11-25 23:43:58 UTC
This is used to associate GtkApplication -> X window, and will
be consumed by gnome-shell.
Comment 1 Colin Walters 2011-11-25 23:43:59 UTC
Created attachment 202158 [details] [review]
Load _DBUS_APPLICATION_ID property, expose it via API
Comment 2 Matthias Clasen 2011-11-27 17:57:21 UTC
Review of attachment 202158 [details] [review]:

::: src/core/window.c
@@ +442,3 @@
+  g_object_class_install_property (object_class,
+                                   PROP_DBUS_APPLICATION_ID,
+                                   g_param_spec_string ("dbus-applicaiton-id",

typo: dbus-application-id
Comment 3 Matthias Clasen 2011-11-27 17:58:02 UTC
Shouldn't this depend on a gtk bug to set the new property ?
Comment 4 Colin Walters 2011-11-27 19:51:19 UTC
(In reply to comment #3)
> Shouldn't this depend on a gtk bug to set the new property ?

I'd intended to push this to the branch, done now:

http://git.gnome.org/browse/gtk+/commit/?h=wip/gmenu&id=563f03f03322ba6a7ee197a0f9b8f8374b6901ae
Comment 5 Owen Taylor 2011-12-13 20:47:32 UTC
Review of attachment 202158 [details] [review]:

OK to commit with minor fixes

::: src/core/window-props.c
@@ +1604,3 @@
+    new_id = value->v.str;
+
+  if (g_strcmp0 (new_id, current_id))

strongly prefer g_strcmp0() != 0

@@ +1611,3 @@
+        window->dbus_application_id = g_strdup (new_id);
+      else
+        window->dbus_application_id = NULL;

g_strdup (NULL) is defined to be NULL, fwiw
Comment 6 Colin Walters 2011-12-15 15:13:06 UTC
Attachment 202158 [details] pushed as 8ab5cc8 - Load _DBUS_APPLICATION_ID property, expose it via API