GNOME Bugzilla – Bug 664683
inner-border: 1; adds additional spacing, preventing getting 2x 80x25 terminals side-by-side on 1280 pixels
Last modified: 2011-11-28 12:57:35 UTC
Forwarded from: https://bugs.launchpad.net/ubuntu/+source/vte/+bug/893174 It would appear that the fix for bug #640460 ("shrinking terminal on tab switch") made terminals 2 pixels wider each. This appears to be the result of the following commit initialising "-VteTerminal-inner-border: 1;". git show 31b4047a | grep -B6 -A3 '^\+.*inner-border' +#if GTK_CHECK_VERSION (2, 99, 0) + klass->priv = G_TYPE_CLASS_GET_PRIVATE (klass, VTE_TYPE_TERMINAL, VteTerminalClassPrivate); + + klass->priv->style_provider = GTK_STYLE_PROVIDER (gtk_css_provider_new ()); + gtk_css_provider_load_from_data (GTK_CSS_PROVIDER (klass->priv->style_provider), + "VteTerminal {\n" + "-VteTerminal-inner-border: 1;\n" + "}\n", + -1, NULL); +#endif /* GTK 3.0 */ commit 31b4047a51ac48264b735a8be24fdddd3b086acc Author: Christian Persch <chpe@gnome.org> Date: Wed Feb 2 18:45:41 2011 +0100 Add default style provider This fixes the default value for the 'inner-border' property not to be NULL. Bug #640460.
Why is that a bug?
Christian: thank you for the patch to the original issue. In the linked downstream bug report: https://bugs.launchpad.net/ubuntu/+source/vte/+bug/893174 a user has reported a regression, in that two 80x25 terminals no longer fit side by side. This appears to have affected their workflow. Presumably it would be possibly to ensure that the value is always initialised. But still initialised to the old value of zero pixels extraneous padding (instead of one pixel)?
Why is 'can't fit two 80 column terminals side-by-side' a bug? The padding exists for a reason (bug 89048), and is themeable (so the user can just change it in his theme), so I don't think I'll change it in vte.
Christian: Thank you for your reasoning and the link bug #89048. I've asked the original reporter to more clearly state their case here. Could you clarify something; my understanding is that bug #89048 was closed (fixed) in 2002 (9 years ago), but that a user has only spotted and reported the padding increased during this last cycle. If bug #89048 is the rationale, was that only "implemented" co-incidentally with fixing bug #640460.
AFAIK even the gtk2 version had a padding of 1px around the widget; failing to take the padding into account caused some bugs in g-t (e.g. at least bug 570591, and a context menu bug). I guess it's possible this regressed at some point; or maybe your distro has had a patch that removes the padding?