GNOME Bugzilla – Bug 664625
the "cut" in the workspace pager is not working well
Last modified: 2012-03-19 22:30:10 UTC
*) drag a window to the lower edge of a thumbnail, so that the "cut" is triggered, but don't go over the placeholder. Drop the window. It should appear in a new workspace, instead it is moved to the workspace under the pointer. *) drag a window to the upper edge ot a thumbnail. The "cut" is not triggered *) the pointer cursor is not updated correctly when dragging a window over thumbnails
Created attachment 201984 [details] [review] fixes for the drop placeholder
This patch includes command line color information. You need to upload a patch created by 'git format-patch'.
Created attachment 202002 [details] [review] placeholder fixes ops.. maybe "git config color.ui always" is not a good idea :)
Created attachment 202047 [details] [review] placeholder fixes Updated patch after master has been ported to Lang.Class framework
Created attachment 202822 [details] [review] workspaceThumbnail: use the correct coordinates when handling the workspace cut The coordinates passed to the handleDragOver function are relative to the actor, so do not treat them as unscaled coordinates
Review of attachment 202822 [details] [review]: Marking needs-work on the unconfirmed suspicion that there's a better way to handle it - see below ::: js/ui/workspaceThumbnail.js @@ +436,2 @@ // Bubble up if we're in the "workspace cut". + let [HScale, VScale] = this.actor.get_scale(); as a style point, this is hScale, vScale @@ +447,3 @@ + // of removing the drop placeholder. The return value is ignored. + if (source.realWindow && !this._isMyWindow(source.realWindow)) { + this._thumbnailsBox.handleDragOver(source, actor, targX, targY, time); This is _really_ ugly. Can we move the handling that we need from Thumbnails.handleDragOver to ThumbnailsBox.onDragMotion? If we need handling that overrides the heirarchy of drop sites, that seems like the better way to do it.
Fixed along with bug 643319 by commit 369c1b0