After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 664309 - On-screen keyboard unavailable in system-modal dialogs
On-screen keyboard unavailable in system-modal dialogs
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: keyboard
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-11-18 01:22 UTC by Matthias Clasen
Modified: 2013-01-21 13:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ShellGlobal: don't return CURRENT_TIME when there is no current event (1.22 KB, patch)
2012-07-20 13:45 UTC, Giovanni Campagna 		rejected Details | Review
Keyboard: fix timestamp handling to account for CURRENT_TIME (2.38 KB, patch)
2012-07-20 14:13 UTC, Giovanni Campagna 		committed Details | Review

Description Matthias Clasen 2011-11-18 01:22:41 UTC 
the keyboard does not pop up on its own when an entry in a system-modal dialog is entered, and the message tray is not accessible for popping it up manually.
Comment 1 Richard Merlier 2011-11-26 13:27:24 UTC 
I noticed the same problem.
For me it's really a critical bug, as you can't type password on tablets systems, so you can't change firewall rules, install packages, log-on after sleep.
Comment 2 Gendre Sébastien 2012-04-02 13:17:37 UTC 
Same problem. 

I'm using Fedora on a WeTab at work and it's a critical bug for us.
Comment 3 Giovanni Campagna 2012-07-20 13:45:34 UTC 
I had this problem on the screen-shield too, and tracked down to be a timestamp issue.

Possible patch coming.
Comment 4 Giovanni Campagna 2012-07-20 13:45:58 UTC 
Created attachment 219325 [details] [review]
ShellGlobal: don't return CURRENT_TIME when there is no current event

On screen keyboard focus handling breaks if grab_key_focus is called
and there is no event in the stack, as 0 compares lower than any
valid timestamp.
Comment 5 Giovanni Campagna 2012-07-20 14:13:21 UTC 
Created attachment 219327 [details] [review]
Keyboard: fix timestamp handling to account for CURRENT_TIME

CLUTTER_CURRENT_TIME (differently from GDK_CURRENT_TIME) is 0,
and thus compares lower than all valid timestamps, meaning that
focus changes without an X11 event in the stack are ignored by
the on screen keyboard.
Comment 6 Giovanni Campagna 2012-08-13 23:47:46 UTC 
I'm not particularly confident when it comes to focus handling, so I'd like to have a review as soon as possible, so any bugs get caught sooner.
Comment 7 Giovanni Campagna 2012-09-13 21:30:07 UTC 
Ping? It's a year-old bug after all, some attention would not be bad...
Comment 8 Jasper St. Pierre (not reading bugmail) 2012-09-13 21:40:00 UTC 
Review of attachment 219325 [details] [review]:

"compares lower"?
Comment 9 Jasper St. Pierre (not reading bugmail) 2012-09-13 21:41:14 UTC 
Review of attachment 219327 [details] [review]:

Oh, I didn't see that the other patch was rejected. This looks fine.
Comment 10 Giovanni Campagna 2012-09-13 21:49:38 UTC 
Attachment 219327 [details] pushed as bf2d207 - Keyboard: fix timestamp handling to account for CURRENT_TIME