After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 664037 - [ffmpegdec]Do not adjust frame duration for repeat if it was already adjusted by upstream element
[ffmpegdec]Do not adjust frame duration for repeat if it was already adjusted...
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-libav
0.10.x
Other Mac OS
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-11-14 14:37 UTC by Matej Knopp
Modified: 2013-07-23 11:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (3.34 KB, patch)
2011-11-14 14:37 UTC, Matej Knopp 		none Details | Review

Description Matej Knopp 2011-11-14 14:37:21 UTC 
Created attachment 201372 [details] [review]
Patch

FFmpegdec always adjusts frame duration picture with repeat set (i.e. telecine), even though the upstream element (parser) might have already computed the correct frame duration. This goes wrong because the new duration is computed relative to the provided one.

Patch corrects this so that ffmpegdec attempts to determine if the correct frame duration has already been set.
Comment 1 Vincent Penquerc'h 2012-01-17 11:51:50 UTC 
Do you have a test case which shows the issue fixed by your patch ?
Comment 2 Matej Knopp 2012-01-17 19:07:01 UTC 
Any mpeg2 telecine file with #664034 applied. I can send you a test file if you want one.
Comment 3 Vincent Penquerc'h 2012-01-17 19:42:06 UTC 
If you can attach a small sample it'd be best.
Comment 4 Matej Knopp 2012-01-17 19:49:11 UTC 
You can download the file here

http://s3.amazonaws.com/MatejK/Samples/small.mpg

can be used to reproduce https://bugzilla.gnome.org/show_bug.cgi?id=664034 as well
Comment 5 Edward Hervey 2013-07-23 11:55:48 UTC 
Was fixed when ported to GstVideoDecoder.