After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 664028 - Do no use the Clutter default stage
Do no use the Clutter default stage
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on: 664052 664497
Blocks:
 
 
Reported: 2011-11-14 12:40 UTC by Emmanuele Bassi (:ebassi)
Modified: 2011-12-15 21:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Do no use the Clutter default stage (998 bytes, patch)
2011-11-14 12:40 UTC, Emmanuele Bassi (:ebassi) 		rejected Details | Review
Do not use the default stage (967 bytes, patch)
2011-11-21 20:25 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Emmanuele Bassi (:ebassi) 2011-11-14 12:40:29 UTC 
There's no reason for using the default stage singleton, and clutter_stage_get_default() has been deprecated in Clutter 1.9/1.10.
Comment 1 Emmanuele Bassi (:ebassi) 2011-11-14 12:40:32 UTC 
Created attachment 201366 [details] [review]
Do no use the Clutter default stage

Mutter has no reason whatsoever for using the default stage: the
compositor owns the stage, and it already track the stage singleton
instance.
Comment 2 Emmanuele Bassi (:ebassi) 2011-11-14 14:06:36 UTC 
main issue: gnome-shell assumes that the default stage is set and used, so we cannot just apply this patch while gnome-shell uses clutter_stage_get_default() as well, otherwise we'll have two stages (one from mutter, one from the plugin).
Comment 3 Colin Walters 2011-11-14 15:57:43 UTC 
Review of attachment 201366 [details] [review]:

We want separate screens to have separate stages, right?  So this change makes sense from that perspective
Comment 4 Emmanuele Bassi (:ebassi) 2011-11-14 16:28:56 UTC 
yes, it does, but it cannot be committed until we make gnome-shell only use the Stage that is created by the plugin. currently, gnome-shell uses the default stage during its initialization process, before the compositor plugin actually has a chance to initialize itself.

I opened bug 664052 for tracking that particular issue.
Comment 5 Jasper St. Pierre (not reading bugmail) 2011-11-21 18:14:14 UTC 
Review of attachment 201366 [details] [review]:

This will not work. The stage needs to be realized, since we do a bunch of raw X calls directly underneath.
Comment 6 Jasper St. Pierre (not reading bugmail) 2011-11-21 20:25:17 UTC 
Created attachment 201860 [details] [review]
Do not use the default stage
Comment 7 Emmanuele Bassi (:ebassi) 2011-11-22 01:27:32 UTC 
Review of attachment 201860 [details] [review]:

looks good to me
Comment 8 Owen Taylor 2011-12-15 17:13:47 UTC 
Review of attachment 201860 [details] [review]:

Looks fine to commit to me (in sync with the gnome-shell change, of course)
Comment 9 Jasper St. Pierre (not reading bugmail) 2011-12-15 21:06:21 UTC 
Attachment 201860 [details] pushed as 264c555 - Do not use the default stage