After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 663590 - [PATCH] Fix btrfs volume label reading
[PATCH] Fix btrfs volume label reading
Status: RESOLVED FIXED
Product: gparted
Classification: Other
Component: application
GIT HEAD
Other Linux
: Normal minor
: ---
Assigned To: gparted maintainers alias
gparted maintainers alias
Depends on:
Blocks:
 
 
Reported: 2011-11-07 23:15 UTC by Mike Fleetwood
Modified: 2011-12-13 17:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
btrfs label reading patch (1.55 KB, patch)
2011-11-07 23:15 UTC, Mike Fleetwood 		none Details | Review

Description Mike Fleetwood 2011-11-07 23:15:31 UTC 
Created attachment 200939 [details] [review]
btrfs label reading patch

Hi,

Quoting the patch message ...

There are still 2 issues with reading btrfs labels when falling back
on using btrfs-show command, rather than primary method of using the
blkid command:

1)  Label is set no "none" when btrfs-show is reporting there is no
    label, although it is impossible to distinguish from the case of the
    label actually being set to "none".

2)  The label has 2 trailing spaces appended as the regular expression
    matches "Label: (btrfslabel  )uuid:" rather than
    "Label: (btrfslabel)  uuid:" in the btrfs-show output.

Assume a label "none" means there is no label and fix the regular
expression.

Thanks,
Mike
Comment 1 Curtis Gedak 2011-11-08 15:58:24 UTC 
Thank you Mike for identifying this problem and creating a patch.

Your patch has been committed to the git repository for inclusion in the next release of GParted.

The relevant git commit can be viewed at the following link:
http://git.gnome.org/browse/gparted/commit/?id=cbd3170e579cc1794ada5316858829e58fbfcb85
Comment 2 Curtis Gedak 2011-12-13 17:41:26 UTC 
The enhancement to address this bug report has been included in GParted 0.11.0 released on Dec. 13, 2011.