After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 663584 - shell-wm: Remove takeover_keybinding()
shell-wm: Remove takeover_keybinding()
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on: 663428
Blocks:
 
 
Reported: 2011-11-07 19:39 UTC by Florian Müllner
Modified: 2011-11-21 23:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
shell-wm: Remove takeover_keybinding() (9.87 KB, patch)
2011-11-07 19:39 UTC, Florian Müllner 		accepted-commit_now Details | Review
shell-wm: Remove takeover_keybinding() (10.48 KB, patch)
2011-11-21 20:31 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2011-11-07 19:39:32 UTC 
See patch.
Comment 1 Florian Müllner 2011-11-07 19:39:34 UTC 
Created attachment 200923 [details] [review]
shell-wm: Remove takeover_keybinding()

Introspection support is now good enough to set a custom keybinding
handler directly from JS.
Comment 2 Jasper St. Pierre (not reading bugmail) 2011-11-07 19:47:06 UTC 
Review of attachment 200923 [details] [review]:

Makes sense.
Comment 3 Florian Müllner 2011-11-21 20:31:12 UTC 
Created attachment 201864 [details] [review]
shell-wm: Remove takeover_keybinding()

Use accessor functions instead of struct access (see corresponding mutter bug)
Comment 4 Florian Müllner 2011-11-21 23:46:03 UTC 
Attachment 201864 [details] pushed as d714dfd - shell-wm: Remove takeover_keybinding()