After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 663366 - Mouse events on the last pixel row aren't delivered to applications
Mouse events on the last pixel row aren't delivered to applications
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: message-tray
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 665042 667915 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-11-04 00:42 UTC by Rui Matos
Modified: 2012-01-14 21:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
messageTray: use a "hot corner" to summon the tray (2.80 KB, patch)
2011-11-04 00:42 UTC, Rui Matos
accepted-commit_now Details | Review
messageTray: use a "hot corner" to summon the tray (2.69 KB, patch)
2011-11-13 22:47 UTC, Rui Matos
committed Details | Review

Description Rui Matos 2011-11-04 00:42:32 UTC
See attached patch for a possible fix.
Comment 1 Rui Matos 2011-11-04 00:42:35 UTC
Created attachment 200655 [details] [review]
messageTray: use a "hot corner" to summon the tray

Instead of leaving the tray covering the whole last pixel row when it's
hidden, hide it completely. This avoids mouse events not being delivered to
application windows on the last pixel row.

To summon the tray we use a single reactive pixel on the corner.
Comment 2 Jasper St. Pierre (not reading bugmail) 2011-11-11 23:10:15 UTC
Review of attachment 200655 [details] [review]:

The only potential issue is that you cannot access the tray by hovering somewhere near the right when you have a lot of sources. But I think this is a quirk anyway, so go for it.
Comment 3 Rui Matos 2011-11-13 22:47:23 UTC
Created attachment 201331 [details] [review]
messageTray: use a "hot corner" to summon the tray

Meanwhile I noticed that the corner pixel wouldn't let events through to the
summary area item underneath it (clicks to activate the item wouldn't
work). It would also cause hover events when moving the pointer from elsewhere
in the summary area to it which closes the tray.

I fixed both these issues by stacking the corner actor underneath the tray
meaning that when the tray is up the corner doesn't get events.

Sorry to have you re-review this, thanks.
Comment 4 Jasper St. Pierre (not reading bugmail) 2011-12-01 18:08:22 UTC
Review of attachment 201331 [details] [review]:

Seems fine to me.
Comment 5 Rui Matos 2011-12-05 04:58:29 UTC
Attachment 201331 [details] pushed as 0cbaeae - messageTray: use a "hot corner" to summon the tray
Comment 6 Kamil Páral 2011-12-08 18:04:40 UTC
*** Bug 665042 has been marked as a duplicate of this bug. ***
Comment 7 Rui Matos 2012-01-14 21:19:25 UTC
*** Bug 667915 has been marked as a duplicate of this bug. ***