After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 662953 - x11: Fix window manager change detection
x11: Fix window manager change detection
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2011-10-28 16:49 UTC by Rui Matos
Modified: 2011-11-05 05:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
x11: Fix window manager change detection (1.70 KB, patch)
2011-10-28 16:49 UTC, Rui Matos 		accepted-commit_now Details | Review
x11: Fix window manager change detection (1.77 KB, patch)
2011-11-05 05:37 UTC, Matthias Clasen 		committed Details | Review

Description Rui Matos 2011-10-28 16:49:35 UTC 
We aren't correctly checking when the _NET_SUPPORTING_WM_CHECK window is
destroyed. See attached patch.
Comment 1 Rui Matos 2011-10-28 16:49:39 UTC 
Created attachment 200197 [details] [review]
x11: Fix window manager change detection

Since the wmspec_check_window doesn't have a corresponding GdkWindow we can't
rely on the get_event_window() return value to get the XID from. Just use the
XID from the XEvent directly.
Comment 2 Matthias Clasen 2011-10-29 02:22:47 UTC 
Review of attachment 200197 [details] [review]:

Nice catch.
Comment 3 Matthias Clasen 2011-11-05 05:37:56 UTC 
The following fix has been pushed:
8067f6b x11: Fix window manager change detection
Comment 4 Matthias Clasen 2011-11-05 05:37:59 UTC 
Created attachment 200738 [details] [review]
x11: Fix window manager change detection

Since the wmspec_check_window doesn't have a corresponding GdkWindow we can't
rely on the get_event_window() return value to get the XID from. Just use the
XID from the XEvent directly.