GNOME Bugzilla – Bug 662930
OnlineGlom: Related records sometimes have no forward/back pager
Last modified: 2011-12-02 12:44:58 UTC
In this example, there is no navigation pager below the related records portal: http://bagu.org:8080/OnlineGlom/#details:document=debian_repository_analyzer&table=scans&value=0 Maybe that is because of the multi-line text making the rows higher.
Yeah, the long text string is making the cell table vertically larger which is hiding the pager. There are two ways that I can think to solve this: 1) Make the portal expand to when its contents become larger. 2) Don't allow the text to be rendered as a multiple lines. So just render the enough of the data to fill the first line and put an ellipsis (…) at the end. Looking at how Glom behaves, I think option 2 is better. Murray: What do you think?
Sure. That sounds OK.
This commit ensures that the pager buttons will always be displayed: https://gitorious.org/online-glom/gwt-glom/commit/47095ce685a584eb4563ecd87358dc4b98afc2d9 A couple of points: * The overflowing text is clipped without a way to access it. It's probably best to deal with this problem when adding support for editing. * The ellipsis will only be displayed with Firefox >= 7. There's a work-around for older versions of Firefox here: http://mattsnider.com/css/css-string-truncation-with-ellipsis/ Since the way that cells are rendered will change when editing support is added, it's probably not worthwhile worrying about this right now. * We might need to add something specific for Opera as described here: http://www.quirksmode.org/css/textoverflow.html Again, getting things perfect in all browsers should probably be more of a concern when editing support is added. * The related list columns widths are now equally spaced. We might be able to do a better job at allocating the column width based on the size of the data text. There are pro and cons to doing this which can be discussed in bug #664281. * The headers don't show an ellipsis when clipped. I can add this if you think it's useful. I'll let you close this bug if/when you think it's fixed.
I just deployed the latest changes for you to check out: http://bagu.org:8080/OnlineGlom/
> * The headers don't show an ellipsis when clipped. I can add this if you think > it's useful. I would prefer the column titles to not be clipped ever, but that's an issue for bug #664281. Anyway, the main problem is fixed, so let's close this bug. Thanks.
Created attachment 201738 [details] screenshot_truncated_pager.png
Created attachment 201739 [details] screenshot_no_gap.png
Actually, I notice here that the pager buttons are cut off horizontally: http://bagu.org:8080/OnlineGlom/#details:document=debian_repository_analyzer&table=scans&value=0 (See the screenshot_truncated_page.png attachment) Do you see that? I also see that the portal has no gap between the bottom of the portal and the "Comments:" label: http://bagu.org:8080/OnlineGlom/#details:document=music-collection&table=albums&value=1.000000 (See the screenshot_no_gap.png attachment)
Created attachment 201810 [details] html table mockup with portal I don't see those problems on my computer but I think I know what's going on. Can you see if you have the same problem with this mockup?
(In reply to comment #9) > Can you see if you have the same problem with this mockup? No, that looks fine.
I just deployed a new version with these two commits: https://gitorious.org/online-glom/gwt-glom/commit/4b948915e9abfdfef347cb0c82765ea70a8caacf https://gitorious.org/online-glom/gwt-glom/commit/b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c Can you check if the problem is fixed?
It looks good. I'm glad that you managed to do the switch to using tables. Thanks.
The related lists in Notebooks aren't visible: http://bagu.org:8080/OnlineGlom/#details:document=openismus-film-manager&table=scenes&value=0 This change is responsible. I'll try to come up with a fix.
This latest problem should now be fix. Murray: Can you confirm it's working for you?
It looks good to me. It's an additional problem, but I a little concerned that, when the browser window is made narrower, there is no visual indication that there are additional notebook tabs: http://bagu.org:8080/OnlineGlom/#details:document=openismus-film-manager&table=scenes&value=0 But that is a problem of the whole layout, regardless of the notebooks, and I'm not sure what would be correct.
Perhaps there could be a minimum width of the details view. If the browser window gets smaller than this minimum, a horizontal scrollbar could be added. It's just a thought though. I'm not really sure what the best thing to do either. For the notebook tabs, it should be possible to reclaim the padding on the left most tab. It's only a few pixels but it looks kinda strange and that space could be used for the other tabs. Again, just a thought.