After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 662829 - [textoverlay] - silent property looks not well implemented
[textoverlay] - silent property looks not well implemented
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
0.10.x
Other Linux
: Normal normal
: 0.10.36
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-10-27 07:38 UTC by bcxa.sz
Modified: 2011-11-08 12:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
textoverlay: continue processing text when silent (1.33 KB, patch)
2011-10-27 14:55 UTC, Vincent Penquerc'h 		committed Details | Review

Description bcxa.sz 2011-10-27 07:38:16 UTC 
The 'silent' property (to hide and display subtitle during playback)
of official gstreamer textoverlay is also not well implemented.

In textoverlay gst_text_overlay_video_chain(), it just push pure video
data but without consuming the text data. Then
gst_text_overlay_text_chain() will blocked to waiting for the text
data consumed.

For subtitle mixed with av in the same file, the demux will block at
the text demuxing since text data not consumed then will not demux any
followed audio and video data.
Comment 1 Vincent Penquerc'h 2011-10-27 14:55:25 UTC 
Created attachment 200109 [details] [review]
textoverlay: continue processing text when silent

This prevents playback wegding when text buffers are
left to pile up.
Comment 2 Vincent Penquerc'h 2011-10-27 15:00:36 UTC 
The other overlays (cairotextoverlay and tiger) did not have a silent property, I've just added one to those as well.

Can't seem to get cairotextoverlay to work from a file with muxed subtitles though, not sure if it's supposed to support this.
Comment 3 Vincent Penquerc'h 2011-11-08 12:07:02 UTC 
commit 51426a3b2d2b77700de22f75b2091a9f323308ba
Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date:   Thu Oct 27 14:48:52 2011 +0100

    textoverlay: continue processing text when silent
    
    This prevents playback wegding when text buffers are
    left to pile up.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=662829