After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 662806 - Should do URI encoding after 301 redirect response
Should do URI encoding after 301 redirect response
Status: RESOLVED FIXED
Product: libsoup
Classification: Core
Component: HTTP Transport
2.37.x
Other Linux
: Normal normal
: ---
Assigned To: Xan Lopez
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-10-26 21:13 UTC by Tommi Vainikainen
Modified: 2011-11-12 14:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to escape non-ASCII octets in Location received in 301 response (2.03 KB, patch)
2011-10-29 05:51 UTC, Tommi Vainikainen
none Details | Review

Description Tommi Vainikainen 2011-10-26 21:13:30 UTC
When I go to page (in Finnish)

http://www.nordea.fi/Henkil%C3%B6asiakkaat/Kortit+ja+maksut/Kortit/Hinnat/1027322.html

and click link  "Päivittäiset raha-asiat/Tiliasiointi" at the bottom, I get error page Too many redirects from Epiphany. With Firefox the link works fine.

Analysis of the issue:

The webserver is running MS-IIS, and it responds first with 301 redirect for the first real redirect. However 301-response "Location" header is not URI/percent encoded correctly (against URI specification). Then Epiphany requests the moved page by simply copying URI from Location header without percent encoding non-ASCII octets. Then MS-IIS re-answers with 301 moved to the same path.

Failure is really MS-IIS here, but Firefox seems to percent encode non-ASCII octets received in the 301 response Location header, and thus Firefox received the page I was expecting.

Please percent encode URIs even in this case.
Comment 1 Tommi Vainikainen 2011-10-29 05:51:36 UTC
Created attachment 200237 [details] [review]
Patch to escape non-ASCII octets in Location received in 301 response

Patch to escape non-ASCII octets in Location received in 301 response. This is also what Firefox does.
Comment 2 Dan Winship 2011-11-12 14:29:03 UTC
I committed a simpler patch to master