After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 662667 - basetransform: fix ref leak
basetransform: fix ref leak
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
unspecified
Other All
: Normal blocker
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-10-25 12:23 UTC by Vincent Penquerc'h
Modified: 2011-10-31 12:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
basetransform: fix ref leak (877 bytes, patch)
2011-10-25 12:23 UTC, Vincent Penquerc'h 		none Details | Review

Description Vincent Penquerc'h 2011-10-25 12:23:43 UTC 
introduced by me with the caps caching patch.
Comment 1 Vincent Penquerc'h 2011-10-25 12:23:45 UTC 
Created attachment 199922 [details] [review]
basetransform: fix ref leak
Comment 2 Vincent Penquerc'h 2011-10-31 10:19:39 UTC 
regression, and simple fix, marking as blocker.
Comment 3 Tim-Philipp Müller 2011-10-31 10:55:32 UTC 
Was this fixed by

 commit 9a5109b86e51eeb726a145b3d5067de932f1ae28
 Author: Jan Schmidt <thaytan@noraisin.net>
 Date:   Thu Oct 27 23:08:14 2011 +1100

    basetransform: Fix refcount leak
    
    Don't leak peercaps and a ref to the basetransform when returning
    the cached caps.

?
Comment 4 Vincent Penquerc'h 2011-10-31 11:15:54 UTC 
Ah, I guess so, I'm in a bad time to pull to check atm.
Comment 5 Vincent Penquerc'h 2011-10-31 12:13:49 UTC 
Yes, that patch includes the ref leak fix, so closing.