After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 662481 - Clean up the gtkprivate directory redefinition mess
Clean up the gtkprivate directory redefinition mess
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2011-10-22 22:02 UTC by Michael Natterer
Modified: 2011-10-23 19:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
The patch (35.80 KB, patch)
2011-10-22 22:02 UTC, Michael Natterer 		accepted-commit_now Details | Review
fix unterminated #ifdef error (738 bytes, patch)
2011-10-23 19:44 UTC, Dieter Verfaillie 		none Details | Review

Description Michael Natterer 2011-10-22 22:02:19 UTC 
See log message of attached patch. Work on X11 and Quartz, and needs
Win32 testing.
Comment 1 Michael Natterer 2011-10-22 22:02:55 UTC 
Created attachment 199738 [details] [review]
The patch
Comment 2 Matthias Clasen 2011-10-23 07:40:52 UTC 
Review of attachment 199738 [details] [review]:

nice cleanup

::: gtk/gtkmainprivate.h
@@ +26,1 @@
 gboolean _gtk_module_has_mixed_deps (GModule *module);

Looks like _gtk_module_has_mixed_deps could easily go into the new gtkmodulesprivate.h ?
Comment 3 Michael Natterer 2011-10-23 11:59:18 UTC 
Indeed, and gtkmainprivate.h can go down the canal. Pushed both patches.
Comment 4 Dieter Verfaillie 2011-10-23 19:44:47 UTC 
Created attachment 199775 [details] [review]
fix unterminated #ifdef error